This repository was archived by the owner on Jul 10, 2023. It is now read-only.
Impl cm postfix #28
Merged
Impl cm postfix #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's my understanding that the ComputedStyle gets normalized in netsurf to one of: absolute value in px (or pt) or percentage value. I'm not sure why it has both px and pt. It would be better if it had only one of them. I understand we need to intake cm values, but shouldnt' they get normalized internally? @SimonSapin care to weigh in? |
|
@metajack Yes all CSS absolute length units should be converted to one as soon as parsing (maybe modulo CSSOM, but we can figure that out later.) See my comments on the related PR: servo/servo#723 (comment) |
|
@SimonSapin Is it ok? |
|
Yes, this does look better. |
|
r+, but this needs a rebase since the fixed test case got merged first. |
|
r? @metajack |
kmcallister
pushed a commit
to kmcallister/servo
that referenced
this pull request
Oct 30, 2013
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 30, 2019
Related to servo/rust-css#28 Source-Repo: https://github.com/servo/servo Source-Revision: 488972e817a072f23b36e92b02a3cb5cccffa90e UltraBlame original commit: 61016c08b892df48f82bfa75413704c59a15b29d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 30, 2019
Related to servo/rust-css#28 Source-Repo: https://github.com/servo/servo Source-Revision: 488972e817a072f23b36e92b02a3cb5cccffa90e UltraBlame original commit: 61016c08b892df48f82bfa75413704c59a15b29d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
Related to servo/rust-css#28 Source-Repo: https://github.com/servo/servo Source-Revision: 488972e817a072f23b36e92b02a3cb5cccffa90e UltraBlame original commit: 61016c08b892df48f82bfa75413704c59a15b29d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to servo/servo#723