Micro-optimize push() and insert(). #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @mbrubeck |
This helps with some micro-benchmarks in Firefox where we end up pushing thousands of elements to a SmallVec. See https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=78b672e152c65fbacd3f0bccc4bd069b177addd6&originalSignature=4765498&newSignature=4765498&framework=1&application=firefox&originalRevision=6f0164143af00325c9f15e7c6387d8f9c7993daf&page=1&showOnlyConfident=1
emilio
force-pushed
the
push-microoptimize
branch
from
ca52f03 to
6b4e119
Compare
|
Fixed MSRV, I think. |
|
https://bugzilla.mozilla.org/show_bug.cgi?id=1853969 is the regression this addresses. |
dshin-moz
reviewed
Sep 20, 2023
| // so that the optimizer removes duplicated calls to it | ||
| // from callers like insert() | ||
| // prefer triple_mut() even if triple() would work so that the optimizer removes duplicated | ||
| // calls to it from callers. |
There was a problem hiding this comment.
So then, does this comment make sense anymore?
There was a problem hiding this comment.
Potentially? In code like:
vec.try_reserve(1)?;
vec.push(...);
It might still be useful / let the compiler optimize more.
mbrubeck
approved these changes
Sep 20, 2023
|
Merged to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with some micro-benchmarks in Firefox where we end up pushing thousands of elements to a SmallVec.
See https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=78b672e152c65fbacd3f0bccc4bd069b177addd6&originalSignature=4765498&newSignature=4765498&framework=1&application=firefox&originalRevision=6f0164143af00325c9f15e7c6387d8f9c7993daf&page=1&showOnlyConfident=1