Skip to content

Commit daabdde

Browse files
nicalgithub-sync
authored andcommitted
Bug 1618132 - Avoid redundant hit test tree builds. r=gw
build_frame is called by update_document which calls rebuild_hit_tester if the hit test tree is invalidated. The advantage of doing it there is that it is after the frame has been submitted to the renderer so we are out of the critical path and the work can overlap with draw call submission. So we don't need to do the work in build_frame, and since we don't currently set the validity flag there we are often re-building the hit test tree a second time after frame building. Differential Revision: https://phabricator.services.mozilla.com/D64328 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/2c6a51317166bb8b3c90781b3bc7739448c72a0b
1 parent 5229910 commit daabdde

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

webrender/src/render_backend.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -581,15 +581,10 @@ impl Document {
581581
tile_cache_logger,
582582
);
583583

584-
let hit_tester = Arc::new(self.scene.create_hit_tester(&self.data_stores.clip));
585-
self.hit_tester = Some(Arc::clone(&hit_tester));
586-
self.shared_hit_tester.update(hit_tester);
587-
588584
frame
589585
};
590586

591587
self.frame_is_valid = true;
592-
self.hit_tester_is_valid = true;
593588

594589
let is_new_scene = self.has_built_scene;
595590
self.has_built_scene = false;

0 commit comments

Comments
 (0)