Address review comment to rename query_with_param_types to query_typed

Author: ramnivas

tokio-postgres/src/client.rs

@@ -382,7 +382,7 @@ impl Client {
     /// use tokio_postgres::types::Type;
     /// use futures_util::{pin_mut, TryStreamExt};
     ///
-    /// let rows = client.query_with_param_types(
+    /// let rows = client.query_typed(
     ///     "SELECT foo FROM bar WHERE biz = $1 AND baz = $2",
     ///     &[(&"first param", Type::TEXT), (&2i32, Type::INT4)],
     /// ).await?;
@@ -394,7 +394,7 @@ impl Client {
     /// # Ok(())
     /// # }
     /// ```
-    pub async fn query_with_param_types(
+    pub async fn query_typed(
         &self,
         statement: &str,
         params: &[(&(dyn ToSql + Sync), Type)],
@@ -406,7 +406,7 @@ impl Client {
                 .map(|(param, param_type)| (*param as _, param_type.clone()))
         }
 
-        query::query_with_param_types(&self.inner, statement, slice_iter(params))
+        query::query_typed(&self.inner, statement, slice_iter(params))
             .await?
             .try_collect()
             .await

tokio-postgres/src/generic_client.rs

@@ -56,8 +56,8 @@ pub trait GenericClient: private::Sealed {
         I: IntoIterator<Item = P> + Sync + Send,
         I::IntoIter: ExactSizeIterator;
 
-    /// Like [`Client::query_with_param_types`]
-    async fn query_with_param_types(
+    /// Like [`Client::query_typed`]
+    async fn query_typed(
         &self,
         statement: &str,
         params: &[(&(dyn ToSql + Sync), Type)],
@@ -146,12 +146,12 @@ impl GenericClient for Client {
         self.query_raw(statement, params).await
     }
 
-    async fn query_with_param_types(
+    async fn query_typed(
         &self,
         statement: &str,
         params: &[(&(dyn ToSql + Sync), Type)],
     ) -> Result<Vec<Row>, Error> {
-        self.query_with_param_types(statement, params).await
+        self.query_typed(statement, params).await
     }
 
     async fn prepare(&self, query: &str) -> Result<Statement, Error> {
@@ -244,12 +244,12 @@ impl GenericClient for Transaction<'_> {
         self.query_raw(statement, params).await
     }
 
-    async fn query_with_param_types(
+    async fn query_typed(
         &self,
         statement: &str,
         params: &[(&(dyn ToSql + Sync), Type)],
     ) -> Result<Vec<Row>, Error> {
-        self.query_with_param_types(statement, params).await
+        self.query_typed(statement, params).await
     }
 
     async fn prepare(&self, query: &str) -> Result<Statement, Error> {

tokio-postgres/src/query.rs

@@ -61,7 +61,7 @@ where
     })
 }
 
-pub async fn query_with_param_types<'a, P, I>(
+pub async fn query_typed<'a, P, I>(
     client: &Arc<InnerClient>,
     query: &str,
     params: I,

tokio-postgres/src/transaction.rs

@@ -227,13 +227,13 @@ impl<'a> Transaction<'a> {
         query::query_portal(self.client.inner(), portal, max_rows).await
     }
 
-    /// Like `Client::query_with_param_types`.
-    pub async fn query_with_param_types(
+    /// Like `Client::query_typed`.
+    pub async fn query_typed(
         &self,
         statement: &str,
         params: &[(&(dyn ToSql + Sync), Type)],
     ) -> Result<Vec<Row>, Error> {
-        self.client.query_with_param_types(statement, params).await
+        self.client.query_typed(statement, params).await
     }
 
     /// Like `Client::copy_in`.

tokio-postgres/tests/test/main.rs

@@ -954,7 +954,7 @@ async fn deferred_constraint() {
 }
 
 #[tokio::test]
-async fn query_with_param_types_no_transaction() {
+async fn query_typed_no_transaction() {
     let client = connect("user=postgres").await;
 
     client
@@ -971,7 +971,7 @@ async fn query_with_param_types_no_transaction() {
         .unwrap();
 
     let rows: Vec<tokio_postgres::Row> = client
-        .query_with_param_types(
+        .query_typed(
             "SELECT name, age, 'literal', 5 FROM foo WHERE name <> $1 AND age < $2 ORDER BY age",
             &[(&"alice", Type::TEXT), (&50i32, Type::INT4)],
         )
@@ -993,7 +993,7 @@ async fn query_with_param_types_no_transaction() {
 }
 
 #[tokio::test]
-async fn query_with_param_types_with_transaction() {
+async fn query_typed_with_transaction() {
     let mut client = connect("user=postgres").await;
 
     client
@@ -1011,7 +1011,7 @@ async fn query_with_param_types_with_transaction() {
     let transaction = client.transaction().await.unwrap();
 
     let rows: Vec<tokio_postgres::Row> = transaction
-        .query_with_param_types(
+        .query_typed(
             "INSERT INTO foo (name, age) VALUES ($1, $2), ($3, $4), ($5, $6) returning name, age",
             &[
                 (&"alice", Type::TEXT),
@@ -1038,7 +1038,7 @@ async fn query_with_param_types_with_transaction() {
     );
 
     let rows: Vec<tokio_postgres::Row> = transaction
-        .query_with_param_types(
+        .query_typed(
             "SELECT name, age, 'literal', 5 FROM foo WHERE name <> $1 AND age < $2 ORDER BY age",
             &[(&"alice", Type::TEXT), (&50i32, Type::INT4)],
         )