Skip to content

Should fallible_iterator be pub? #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liquidscorpio opened this issue Nov 27, 2019 · 1 comment
Closed

Should fallible_iterator be pub? #520

liquidscorpio opened this issue Nov 27, 2019 · 1 comment

Comments

@liquidscorpio
Copy link

liquidscorpio commented Nov 27, 2019

This is to use LazyRows as explained here.

extern crate fallible_iterator;
use fallible_iterator::FallibleIterator;

/// Code involving LazyRow

To use the FallibleIterator, the user needs to add fallible-iterator to their Cargo.toml which can lead to version mismatch. For example, the current latest version for the fallible-iterator crate is 0.2.0 on crates.io but rust-postgres uses 0.1.6 for the same crate.

Keeping the fallible-iterator crate version in local Cargo.toml synchronized with the one used by the postgres crate can be a source of human error leading to subtle bugs.

One option could be to expose the FallibleIterator from postgres crate itself.

@liquidscorpio
Copy link
Author

Thanks @sfackler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant