Merge pull request rust-lang#1316 from CvX/eslint-fix-no-on-calls-in-components

ESLint: fix "ember/no-on-calls-in-components" error.

Author: Turbo87

.eslintrc.js

@@ -29,7 +29,6 @@ module.exports = {
             'allowTemplateLiterals': true,
             'avoidEscape': true,
         }],
-        'ember/no-on-calls-in-components': 'off',
     },
     overrides: [
         // node files

app/components/rl-dropdown.js

@@ -1,13 +1,13 @@
 import Component from '@ember/component';
-import { on } from '@ember/object/evented';
 import { alias } from '@ember/object/computed';
-import { computed, observer } from '@ember/object';
+import { computed } from '@ember/object';
 import $ from 'jquery';
 
 import RlDropdownContainer from './rl-dropdown-container';
 
 export default Component.extend({
     classNames: ['rl-dropdown'],
+    classNameBindings: ['isExpanded:open'],
 
     dropdownContainer: computed(function() {
         return this.nearestOfType(RlDropdownContainer);
@@ -19,14 +19,6 @@ export default Component.extend({
 
     propagateClicks: true,
 
-    manageVisibility: on('didInsertElement', observer('isExpanded', function() {
-        if (this.get('isExpanded')) {
-            this.$().css('display', 'block');
-        } else {
-            this.$().css('display', 'none');
-        }
-    })),
-
     click(event) {
         let closeOnChildClick = this.get('closeOnChildClick');
         let propagateClicks = this.get('propagateClicks');

app/styles/app.scss

@@ -98,19 +98,13 @@ body {
     }
 
     .current-user-links {
-        display: none;
         left: auto;
         right: 0;
         min-width: 200px;
-
-        &.open { display: block; }
     }
     #doc-links {
-        display: none;
         left: auto;
         min-width: 150px;
-
-        &.open { display: block; }
     }
     form.search {
         @include display-flex;
@@ -279,6 +273,7 @@ button.dropdown, a.dropdown {
 }
 
 ul.dropdown {
+    display: none;
     position: absolute;
     top: 100%;
     left: 0;