Skip to content

Commit 8db0511

Browse files
committed
fixes
1 parent 29ade6f commit 8db0511

File tree

1 file changed

+33
-14
lines changed

1 file changed

+33
-14
lines changed

.github/workflows/deploy-to-control-plane-review.yml

Lines changed: 33 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -176,19 +176,38 @@ jobs:
176176
DEPLOYMENT_ID: ${{ env.deploymentId }}
177177
with:
178178
script: |
179-
const message = "❌ Deployment [" + process.env.DEPLOYMENT_ID + "] failed\n\nCommit: " + context.sha.substring(0, 7) + "\nWorkflow Status: " + process.env.statusUrl;
179+
console.log('Debug info:');
180+
console.log('COMMENT_ID:', process.env.COMMENT_ID);
181+
console.log('DEPLOYMENT_ID:', process.env.DEPLOYMENT_ID);
182+
console.log('create-deployment result:', ${{ steps.create-deployment.outputs.result }});
180183
181-
await github.rest.issues.updateComment({
182-
owner: context.repo.owner,
183-
repo: context.repo.repo,
184-
comment_id: process.env.COMMENT_ID,
185-
body: message
186-
});
184+
const message = "❌ Deployment [" + (process.env.DEPLOYMENT_ID || 'unknown') + "] failed\n\nCommit: " + context.sha.substring(0, 7) + "\nWorkflow Status: " + process.env.statusUrl;
187185
188-
await github.rest.repos.createDeploymentStatus({
189-
owner: context.repo.owner,
190-
repo: context.repo.repo,
191-
deployment_id: ${{ steps.create-deployment.outputs.result }},
192-
state: 'failure',
193-
description: '❌ Deployment failed'
194-
});
186+
// Only try to update comment if we have a comment ID
187+
if (process.env.COMMENT_ID) {
188+
await github.rest.issues.updateComment({
189+
owner: context.repo.owner,
190+
repo: context.repo.repo,
191+
comment_id: process.env.COMMENT_ID,
192+
body: message
193+
});
194+
} else {
195+
// Fall back to creating a new comment
196+
await github.rest.issues.createComment({
197+
issue_number: context.issue.number || context.payload.pull_request.number,
198+
owner: context.repo.owner,
199+
repo: context.repo.repo,
200+
body: message
201+
});
202+
}
203+
204+
// Only create deployment status if we have a deployment ID
205+
if (${{ steps.create-deployment.outputs.result }}) {
206+
await github.rest.repos.createDeploymentStatus({
207+
owner: context.repo.owner,
208+
repo: context.repo.repo,
209+
deployment_id: ${{ steps.create-deployment.outputs.result }},
210+
state: 'failure',
211+
description: '❌ Deployment failed'
212+
});
213+
}

0 commit comments

Comments
 (0)