Skip to content

Commit ee5c4f4

Browse files
committed
fix deploy job's dependencies
1 parent a6fe0a3 commit ee5c4f4

File tree

1 file changed

+2
-11
lines changed

1 file changed

+2
-11
lines changed

.github/workflows/deploy-to-control-plane-review-app.yml

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,6 @@ jobs:
244244
issue_number: process.env.PR_NUMBER,
245245
body: '🚀 Starting deployment process...\n\n' + process.env.CONSOLE_LINK
246246
});
247-
// console.log(result);
248247
core.setOutput('comment-id', result.data.id);
249248
250249
- name: Set Deployment URLs
@@ -356,11 +355,9 @@ jobs:
356355
PR_NUMBER: ${{ needs.process-deployment.outputs.pr_number }}
357356

358357
deploy:
359-
needs: build
358+
needs: [build, process-deployment]
360359
if: needs.build.outputs.do_deploy != 'false'
361360
runs-on: ubuntu-latest
362-
env:
363-
COMMENT_ID: ${{ needs.process-deployment.outputs.comment_id }}
364361
steps:
365362
- name: Checkout code
366363
uses: actions/checkout@v4
@@ -371,12 +368,6 @@ jobs:
371368
token: ${{ secrets.CPLN_TOKEN_STAGING }}
372369
org: ${{ vars.CPLN_ORG_STAGING }}
373370

374-
- name: Print Comment id as job output
375-
run: echo '${{ needs.process-deployment.outputs.comment_id }}'
376-
377-
- name: Print Comment id as env var
378-
run: echo $COMMENT_ID
379-
380371
- name: Update Status - Deploying
381372
uses: actions/github-script@v7
382373
with:
@@ -394,7 +385,7 @@ jobs:
394385
await github.rest.issues.updateComment({
395386
owner: context.repo.owner,
396387
repo: context.repo.repo,
397-
comment_id: '${process.env.COMMENT_ID}',
388+
comment_id: ${{ needs.process-deployment.outputs.comment_id }},
398389
body: deployingMessage
399390
});
400391

0 commit comments

Comments
 (0)