Skip to content

Commit 5c2164c

Browse files
committed
add instance method to VersionChecker
1 parent ceb80a0 commit 5c2164c

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

lib/react_on_rails/engine.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
module ReactOnRails
66
class Engine < ::Rails::Engine
77
config.to_prepare do
8-
if VersionChecker.new(NodePackageVersion.new("package.json")).raise_if_gem_and_node_package_versions_differ &&
9-
VersionChecker.new(NodePackageVersion.new("client/package.json")).raise_if_gem_and_node_package_versions_differ
8+
if VersionChecker.instance("package.json").raise_if_gem_and_node_package_versions_differ &&
9+
VersionChecker.instance("client/package.json").raise_if_gem_and_node_package_versions_differ
1010
Rails.logger.warn("No 'react-on-rails' entry found in 'dependencies' in package.json or client/package.json.")
1111
end
1212
ReactOnRails::ServerRenderingPool.reset_pool

lib/react_on_rails/version_checker.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ def self.build
1212
new(NodePackageVersion.build)
1313
end
1414

15+
def self.instance(package_json_path)
16+
new(NodePackageVersion.new(package_json_path))
17+
end
18+
1519
def initialize(node_package_version)
1620
@node_package_version = node_package_version
1721
end

0 commit comments

Comments
 (0)