use isPromise to check if the result is a promise

Author: AbanoubGhadban

node_package/src/isServerRenderResult.ts

@@ -9,7 +9,7 @@ export function isServerRenderHash(testValue: CreateReactOutputResult):
     (testValue as ServerRenderResult).error);
 }
 
-export function isPromise(testValue: CreateReactOutputResult):
-  testValue is Promise<string> {
-  return !!((testValue as Promise<string>).then);
+export function isPromise<T>(testValue: CreateReactOutputResult | Promise<T> | string):
+  testValue is Promise<T> {
+  return !!((testValue as Promise<T>).then);
 }

node_package/src/serverRenderReactComponent.ts

@@ -3,8 +3,7 @@ import type { ReactElement } from 'react';
 
 import ComponentRegistry from './ComponentRegistry';
 import createReactOutput from './createReactOutput';
-import {isServerRenderHash, isPromise} from
-    './isServerRenderResult';
+import { isServerRenderHash, isPromise } from './isServerRenderResult';
 import buildConsoleReplay from './buildConsoleReplay';
 import handleError from './handleError';
 import type { RenderParams, RenderResult, RenderingError } from './types/index';
@@ -162,12 +161,12 @@ const serverRenderReactComponent: typeof serverRenderReactComponentInternal = (o
   } finally {
     // Reset console history after each render.
     // See `RubyEmbeddedJavaScript.console_polyfill` for initialization.
-    if (!result || typeof(result) === 'string') {
-      console.history = [];
-    } else {
+    if (result && isPromise(result)) {
       result.finally(() => {
         console.history = [];
       });
+    } else {
+      console.history = [];
     }
   }
   return result;