Skip to content

Commit ab3fcbc

Browse files
author
Shyam Dharmarajan
committed
Vwan: Hubvnet connection related fixes
Update with review comments. - Fix deprecation error message - Update ChangeLog.md
1 parent ec29a9e commit ab3fcbc

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

src/Network/Network/ChangeLog.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,18 @@
4444
* Add `EnableDnsProxy`, 'DnsProxyNotRequiredForNetworkRule' and 'DnsServer' parameters to `AzureFirewall`
4545
- Updated cmdlet:
4646
- New-AzFirewall
47+
* Add deprecation warning for `HubVnetConnection` parameter in following cmdlets
48+
- NewAzureRmVirtualHubCommand
49+
- UpdateAzureRmVirtualHubCommand
50+
* Use HubVnetConnection create/update APIs instead of VirtualHub create/update APIs for following cmdlets
51+
- NewAzureRmVirtualHubCommand
52+
- UpdateAzureRmVirtualHubCommand
53+
- NewHubVirtualNetworkConnectionCommand
54+
- UpdateAzureRmHubVirtualNetworkConnectionCommand
55+
- RemoveHubVirtualNetworkConnectionCommand
56+
* Deprecate `EnableInternetSecurity` switch parameter and instead introduce `EnableInternetSecurityFlag` boolean in
57+
- NewHubVirtualNetworkConnectionCommand.
58+
The flag is also made true by default for newly created connections.
4759

4860
## Version 2.5.0
4961
* Updated cmdlets to enable connection on private IP for Virtual Network Gateway.

src/Network/Network/Cortex/VirtualHub/NewAzureRmVirtualHubCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public class NewAzureRmVirtualHubCommand : VirtualHubBaseCmdlet
7979
[ValidateNotNullOrEmpty]
8080
public string Location { get; set; }
8181

82-
public const String ChangeDesc = "VirtualNetworkConnection parameter is deprecated. Use AzVirtualHubVnet commands";
82+
public const String ChangeDesc = "HubVnetConnection parameter is deprecated. Use *VirtualHubVnetConnection* commands";
8383
[CmdletParameterBreakingChange("HubVnetConnection", ChangeDescription = ChangeDesc)]
8484
[Parameter(
8585
Mandatory = false,

src/Network/Network/Cortex/VirtualHub/UpdateAzureRmVirtualHubCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public class UpdateAzureRmVirtualHubCommand : VirtualHubBaseCmdlet
7878
HelpMessage = "The address space string for this virtual hub.")]
7979
public string AddressPrefix { get; set; }
8080

81-
public const String ChangeDesc = "VirtualNetworkConnection parameter is deprecated. Use AzVirtualHubVnet commands";
81+
public const String ChangeDesc = "HubVnetConnection parameter is deprecated. Use *VirtualHubVnetConnection* commands";
8282
[CmdletParameterBreakingChange("HubVnetConnection", ChangeDescription = ChangeDesc)]
8383
[Parameter(
8484
Mandatory = false,

0 commit comments

Comments
 (0)