Skip to content

Commit 16fbe9a

Browse files
authored
action: flip release-signing-artifacts (#142)
Signed-off-by: William Woodruff <[email protected]>
1 parent 1ddeb82 commit 16fbe9a

File tree

2 files changed

+8
-13
lines changed

2 files changed

+8
-13
lines changed

README.md

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ Example:
314314

315315
### `release-signing-artifacts`
316316

317-
**Default**: `false`
317+
**Default**: `true`
318318

319319
The `release-signing-artifacts` setting controls whether or not `sigstore-python`
320320
uploads signing artifacts to the release publishing event that triggered this run.
@@ -323,8 +323,6 @@ This setting has no effect on non-`release` events.
323323
If enabled, this setting also re-uploads and signs GitHub's default source code artifacts,
324324
as they are not guaranteed to be stable.
325325

326-
By default, no release assets are uploaded.
327-
328326
Requires the [`contents: write` permission](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token).
329327

330328
Example:
@@ -342,19 +340,16 @@ permissions:
342340
```
343341

344342
On release events, it is also valid to have no explicit inputs. When used on release
345-
events with `release-signing-artifacts: true`, this action will sign any pre-existing
346-
release artifacts:
343+
events, this action will sign any pre-existing release artifacts:
347344

348345
```yaml
349346
permissions:
350347
contents: write
351348
352349
# ...
353350
351+
# no explicit settings needed, signs all pre-existing release artifacts
354352
- uses: sigstore/[email protected]
355-
with:
356-
# Only valid on release events
357-
release-signing-artifacts: true
358353
```
359354

360355
### Internal options

action.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,11 @@ inputs:
4747
staging:
4848
description: "use sigstore's staging instances, instead of the default production instances"
4949
required: false
50-
default: false
50+
default: "false"
5151
verify:
5252
description: "verify the generated signatures after signing"
5353
required: false
54-
default: false
54+
default: "false"
5555
verify-cert-identity:
5656
description: |
5757
verify the identity in the signing certificate's Subject Alternative Name
@@ -69,15 +69,15 @@ inputs:
6969
upload-signing-artifacts:
7070
description: "upload all signing artifacts as workflow artifacts"
7171
required: false
72-
default: false
72+
default: "false"
7373
release-signing-artifacts:
7474
description: "attach all signing artifacts as release assets"
7575
required: false
76-
default: false
76+
default: "true"
7777
internal-be-careful-debug:
7878
description: "run with debug logs (default false)"
7979
required: false
80-
default: false
80+
default: "false"
8181

8282
runs:
8383
using: "composite"

0 commit comments

Comments
 (0)