Skip to content

Commit da238ad

Browse files
authored
Cleanup workflows (#148)
* Workflows: remove default input arg from action call Signed-off-by: Jussi Kukkonen <[email protected]> * workflows: Remove unnecessary selftest release-signing-artifacts defaults to "true" so the removed test now duplicates the previous test. We could try testing the release-signing-artifacts == "false" but that's a bit trickier since it could only be done in a release event... Signed-off-by: Jussi Kukkonen <[email protected]> * workflows: Drop recently removed job from needs-list Signed-off-by: Jussi Kukkonen <[email protected]> --------- Signed-off-by: Jussi Kukkonen <[email protected]>
1 parent 551a497 commit da238ad

File tree

2 files changed

+0
-31
lines changed

2 files changed

+0
-31
lines changed

.github/workflows/release.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,3 @@ jobs:
2323
id: sigstore-python
2424
with:
2525
inputs: action.yml action.py
26-
release-signing-artifacts: true

.github/workflows/selftest.yml

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -93,35 +93,6 @@ jobs:
9393
[[ -f ./test/white\ space.txt ]] || exit 1
9494
[[ -f ./test/more\ white\ space.txt ]] || exit 1
9595
96-
selftest-release-signing-artifacts-no-op:
97-
strategy:
98-
matrix:
99-
os:
100-
- ubuntu-latest
101-
- macos-latest
102-
- windows-latest
103-
runs-on: ${{ matrix.os }}
104-
if: (github.event_name != 'pull_request') || !github.event.pull_request.head.repo.fork
105-
steps:
106-
- uses: actions/checkout@v4
107-
- uses: actions/setup-python@v5
108-
if: ${{ matrix.os != 'ubuntu-latest' }}
109-
with:
110-
python-version: "3.x"
111-
- name: Sign artifact and publish signature
112-
uses: ./
113-
id: sigstore-python
114-
with:
115-
inputs: ./test/artifact.txt
116-
# The trigger for this test is not a release, so this has no effect
117-
# (but does not break the workflow either).
118-
release-signing-artifacts: true
119-
internal-be-careful-debug: true
120-
- name: Check outputs
121-
shell: bash
122-
run: |
123-
[[ -f ./test/artifact.txt.sigstore.json ]] || exit 1
124-
12596
selftest-xfail-invalid-inputs:
12697
runs-on: ubuntu-latest
12798
strategy:
@@ -349,7 +320,6 @@ jobs:
349320
needs:
350321
- selftest
351322
- selftest-whitespace
352-
- selftest-release-signing-artifacts-no-op
353323
- selftest-xfail-invalid-inputs
354324
- selftest-staging
355325
- selftest-glob

0 commit comments

Comments
 (0)