Merge pull request #203 from sir-gon/develop

[BUGFIX] Sonarcloud java:S117: Rename this local variable to match th…

Author: sir-gon

algorithm-exercises-java/src/test/java/ae/hackerrank/warmup/BirthdayCakeCandlesTest.java

@@ -18,9 +18,9 @@ public class BirthdayCakeCandlesTestCase {
     public List<Integer> candles;
     public Integer expected;
 
-    public BirthdayCakeCandlesTestCase(List<Integer> _candles, Integer _expected) {
-      this.candles = _candles;
-      this.expected = _expected;
+    public BirthdayCakeCandlesTestCase(List<Integer> candles, Integer expected) {
+      this.candles = candles;
+      this.expected = expected;
     }
   }
 

algorithm-exercises-java/src/test/java/ae/hackerrank/warmup/CompareTripletsTest.java

@@ -18,10 +18,10 @@ public class CompareTripletsTestCase {
     public List<Integer> lb;
     public List<Integer> expected;
 
-    public CompareTripletsTestCase(List<Integer> _la, List<Integer> _lb, List<Integer> _expected) {
-      this.la = _la;
-      this.lb = _lb;
-      this.expected = _expected;
+    public CompareTripletsTestCase(List<Integer> la, List<Integer> lb, List<Integer> expected) {
+      this.la = la;
+      this.lb = lb;
+      this.expected = expected;
     }
   }
 

algorithm-exercises-java/src/test/java/ae/hackerrank/warmup/DiagonalDifferenceTest.java

@@ -17,9 +17,9 @@ public class DiagonalDifferenceTestCase {
     public List<List<Integer>> matrix;
     public Integer expected;
 
-    public DiagonalDifferenceTestCase(List<List<Integer>> _input, int _expected) {
-      this.matrix = _input;
-      this.expected = _expected;
+    public DiagonalDifferenceTestCase(List<List<Integer>> input, int expected) {
+      this.matrix = input;
+      this.expected = expected;
     }
   }
 

algorithm-exercises-java/src/test/java/ae/hackerrank/warmup/MiniMaxSumTest.java

@@ -19,9 +19,9 @@ public class MiniMaxSumTestCase {
     public List<Integer> input;
     public String expected;
 
-    public MiniMaxSumTestCase(List<Integer> _input, String _expected) {
-      this.input = _input;
-      this.expected = _expected;
+    public MiniMaxSumTestCase(List<Integer> input, String expected) {
+      this.input = input;
+      this.expected = expected;
     }
   }
 

algorithm-exercises-java/src/test/java/ae/hackerrank/warmup/PlusMinusTest.java

@@ -16,9 +16,9 @@ public class PlusMinusTestCase {
     public List<Integer> input;
     public String expected;
 
-    public PlusMinusTestCase(List<Integer> _input, String _expected) {
-      this.input = _input;
-      this.expected = _expected;
+    public PlusMinusTestCase(List<Integer> input, String expected) {
+      this.input = input;
+      this.expected = expected;
     }
   }
 

algorithm-exercises-java/src/test/java/ae/hackerrank/warmup/StaircaseTest.java

@@ -15,9 +15,9 @@ public class StaircaseTestCase {
     public Integer input;
     public String expected;
 
-    public StaircaseTestCase(Integer _input, String _expected) {
-      this.input = _input;
-      this.expected = _expected;
+    public StaircaseTestCase(Integer input, String expected) {
+      this.input = input;
+      this.expected = expected;
     }
   }
 

algorithm-exercises-java/src/test/java/ae/hackerrank/warmup/TimeConversionTest.java

@@ -15,9 +15,9 @@ public class TimeConversionTestCase {
     public String input;
     public String expected;
 
-    public TimeConversionTestCase(String _input, String _expected) {
-      this.input = _input;
-      this.expected = _expected;
+    public TimeConversionTestCase(String input, String expected) {
+      this.input = input;
+      this.expected = expected;
     }
   }
 

algorithm-exercises-java/src/test/java/ae/projecteuler/helper/NaturalNumberTest.java

@@ -172,11 +172,11 @@ void initPrimeFactorsOfNumberTestCases() {
           String.format("Must be an instance of %s", NaturalNumber.class)
       );
 
-      final Long[] answer_prime_factors = answer.primeFactors();
-      final Integer answer_prime_factors_cycles = answer.getPrimeFactorCycles();
+      final Long[] answerPrimeFactors = answer.primeFactors();
+      final Integer answerPrimeFactorsCycles = answer.getPrimeFactorCycles();
 
-      assertArrayEquals(expected.factors, answer_prime_factors);
-      assertEquals(expected.cycles, answer_prime_factors_cycles);
+      assertArrayEquals(expected.factors, answerPrimeFactors);
+      assertEquals(expected.cycles, answerPrimeFactorsCycles);
     }
   }
 
@@ -193,9 +193,9 @@ void initPrimeFactorsOfNumberTestCases() {
           String.format("Must be an instance of %s", NaturalNumber.class)
       );
 
-      final Integer answer_prime_factors_cycles = answer.getPrimeFactorCycles();
+      final Integer answerPrimeFactorsCycles = answer.getPrimeFactorCycles();
 
-      assertEquals(expected.cycles, answer_prime_factors_cycles);
+      assertEquals(expected.cycles, answerPrimeFactorsCycles);
     }
   }