[CONFIG] [Gihub Actions] Docker running in splitted jobs.

Author: Gonzalo Diaz

.github/workflows/docker-image.yml

@@ -10,32 +10,12 @@ on: # yamllint disable-line rule:truthy
 
 env:
   IMAGE_NAME: algorithm-exercises-js
+  ARTIFACT_NAME: algorithm-exercises-js_${{ github.sha }}
 
 jobs:
-  security:
-    name: "Snyk Container"
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
-
-      - name: Run Snyk to check Docker image for vulnerabilities
-        # Snyk can be used to break the build when it detects vulnerabilities.
-        # In this case we want to upload the issues to GitHub Code Scanning
-        continue-on-error: true
-        uses: snyk/actions/docker@master
-        env:
-          # yamllint disable rule:line-length
-          # In order to use the Snyk Action you will need to have a Snyk API token.
-          # See https://docs.snyk.io/integrations/ci-cd-integrations/github-actions-integration#getting-your-snyk-token
-          # or you can sign up for free at https://snyk.io/login
-          # yamllint enable rule:line-length
-          SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
-        with:
-          image: ${{ env.IMAGE_NAME }}:${{ github.sha }}
-          args: --file=Dockerfile
 
   build:
-    name: "Build & Test in Docker"
+    name: "Build Docker images"
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
@@ -60,45 +40,45 @@ jobs:
           context: .
           target: lint
           outputs: |
-            type=docker,dest=/tmp/${{ env.IMAGE_NAME }}_${{ github.sha }}_lint.tar
+            type=docker,dest=/tmp/${{ env.ARTIFACT_NAME }}_lint.tar
           tags: |
             ${{ env.IMAGE_NAME }}:lint
       - name: "LINT: Upload artifact"
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ env.IMAGE_NAME }}_${{ github.sha }}_lint
-          path: /tmp/${{ env.IMAGE_NAME }}_${{ github.sha }}_lint.tar
+          name: ${{ env.ARTIFACT_NAME }}_lint
+          path: /tmp/${{ env.ARTIFACT_NAME }}_lint.tar
 
       - name: "TEST: Build and push"
         uses: docker/build-push-action@v6
         with:
           context: .
           target: testing
           outputs: |
-            type=docker,dest=/tmp/${{ env.IMAGE_NAME }}_${{ github.sha }}_test.tar
+            type=docker,dest=/tmp/${{ env.ARTIFACT_NAME }}_test.tar
           tags: |
             ${{ env.IMAGE_NAME }}:test
       - name: "TEST: Upload artifact"
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ env.IMAGE_NAME }}_${{ github.sha }}_test
-          path: /tmp/${{ env.IMAGE_NAME }}_${{ github.sha }}_test.tar
+          name: ${{ env.ARTIFACT_NAME }}_test
+          path: /tmp/${{ env.ARTIFACT_NAME }}_test.tar
 
       - name: "PRODUCTION: Build and push"
         uses: docker/build-push-action@v6
         with:
           context: .
           target: production
           outputs: |
-            type=docker,dest=/tmp/${{ env.IMAGE_NAME }}_${{ github.sha }}_prod.tar
+            type=docker,dest=/tmp/${{ env.ARTIFACT_NAME }}_prod.tar
           tags: |
             ${{ env.IMAGE_NAME }}:latest
             ${{ env.IMAGE_NAME }}:${{ github.sha }}
       - name: "PRODUCTION: Upload artifact"
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ env.IMAGE_NAME }}_${{ github.sha }}_prod
-          path: /tmp/${{ env.IMAGE_NAME }}_${{ github.sha }}_prod.tar
+          name: ${{ env.ARTIFACT_NAME }}_prod
+          path: /tmp/${{ env.ARTIFACT_NAME }}_prod.tar
 
   lint:
     name: "Run in docker: LINT"
@@ -108,17 +88,70 @@ jobs:
       - name: Download artifact
         uses: actions/download-artifact@v4
         with:
-          name: ${{ env.IMAGE_NAME }}_${{ github.sha }}_prod
+          name: ${{ env.ARTIFACT_NAME }}_lint
           path: /tmp/
 
       - name: Load image
         run: |
-          docker load --input /tmp/${{ env.IMAGE_NAME }}_${{ github.sha }}_prod.tar
+          docker load --input /tmp/${{ env.ARTIFACT_NAME }}_lint.tar
           docker image ls -a
 
       - name: Run lint
         run: |
-          make compose/lint
+          docker run --rm ${{ env.IMAGE_NAME }}:lint make lint
+
+  test:
+    name: "Run in docker: TEST"
+    runs-on: ubuntu-latest
+    needs: build
+    steps:
+      - name: Download artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: ${{ env.ARTIFACT_NAME }}_test
+          path: /tmp/
+
+      - name: Load image
+        run: |
+          docker load --input /tmp/${{ env.ARTIFACT_NAME }}_test.tar
+          docker image ls -a
+
+      - name: Run lint
+        run: |
+          docker run --rm ${{ env.IMAGE_NAME }}:test make test
+
+  security:
+    name: "Snyk Container"
+    runs-on: ubuntu-latest
+    needs: build
+    steps:
+      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
+      - name: Download artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: ${{ env.ARTIFACT_NAME }}_prod
+          path: /tmp/
+
+      - name: Load image
+        run: |
+          docker load --input /tmp/${{ env.ARTIFACT_NAME }}_prod.tar
+          docker image ls -a
+
+      - name: Run Snyk to check Docker image for vulnerabilities
+        # Snyk can be used to break the build when it detects vulnerabilities.
+        # In this case we want to upload the issues to GitHub Code Scanning
+        continue-on-error: true
+        uses: snyk/actions/docker@master
+        env:
+          # yamllint disable rule:line-length
+          # In order to use the Snyk Action you will need to have a Snyk API token.
+          # See https://docs.snyk.io/integrations/ci-cd-integrations/github-actions-integration#getting-your-snyk-token
+          # or you can sign up for free at https://snyk.io/login
+          # yamllint enable rule:line-length
+          SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
+        with:
+          image: ${{ env.IMAGE_NAME }}:${{ github.sha }}
+          args: --file=Dockerfile
 
   scan:
     name: "Trivy"
@@ -128,12 +161,12 @@ jobs:
       - name: Download artifact
         uses: actions/download-artifact@v4
         with:
-          name: ${{ env.IMAGE_NAME }}_${{ github.sha }}_prod
+          name: ${{ env.ARTIFACT_NAME }}_prod
           path: /tmp/
 
       - name: Load image
         run: |
-          docker load --input /tmp/${{ env.IMAGE_NAME }}_${{ github.sha }}_prod.tar
+          docker load --input /tmp/${{ env.ARTIFACT_NAME }}_prod.tar
           docker image ls -a
 
       - name: Run Trivy vulnerability scanner