Merge pull request #486 from sir-gon/develop

Develop

Author: sir-gon

src/hackerrank/interview_preparation_kit/arrays/new_year_chaos.js

@@ -29,7 +29,7 @@ export function minimumBribes(q) {
 
 export function minimumBribesTransform(queue) {
   try {
-    return minimumBribes(queue);
+    return minimumBribes(queue).toString(10);
   } catch (e) {
     return TOO_CHAOTIC_ERROR;
   }

src/hackerrank/interview_preparation_kit/arrays/new_year_chaos.test.js

@@ -4,7 +4,7 @@ import { logger as console } from '../../../logger.js';
 import { minimumBribesTransform, TOO_CHAOTIC_ERROR } from './new_year_chaos.js';
 
 const TEST_CASES = [
-  { title: 'Test Case 0-0', input: [2, 1, 5, 3, 4], expected: 3 },
+  { title: 'Test Case 0-0', input: [2, 1, 5, 3, 4], expected: '3' },
   {
     title: 'Test Case 0-1',
     input: [2, 5, 1, 3, 4],
@@ -15,8 +15,8 @@ const TEST_CASES = [
     input: [5, 1, 2, 3, 7, 8, 6, 4],
     expected: TOO_CHAOTIC_ERROR
   },
-  { title: 'Test Case 1-2', input: [1, 2, 5, 3, 7, 8, 6, 4], expected: 7 },
-  { title: 'Test Case 2', input: [1, 2, 5, 3, 4, 7, 8, 6], expected: 4 }
+  { title: 'Test Case 1-2', input: [1, 2, 5, 3, 7, 8, 6, 4], expected: '7' },
+  { title: 'Test Case 2', input: [1, 2, 5, 3, 4, 7, 8, 6], expected: '4' }
 ];
 
 describe('new_year_chaos', () => {

src/hackerrank/interview_preparation_kit/greedy_algorithms/luck-balance.js

@@ -29,19 +29,27 @@ class Contest {
     this.luck = luck;
     this.important = important;
   }
+
+  getLuck() {
+    return this.luck;
+  }
+
+  isImportant() {
+    return this.important !== 0;
+  }
 }
 
 export function luckBalance(k, contests) {
-  // Write your code here
   let importantContests = [];
   const nonimportantContests = [];
 
-  contests.forEach((contest) => {
-    const [luck, important] = [...contest];
-    if (important === 1) {
-      importantContests.push(new Contest(luck, important));
+  contests.forEach((contestData) => {
+    const [luck, important] = [...contestData];
+    const contest = new Contest(luck, important);
+    if (contest.isImportant()) {
+      importantContests.push(contest);
     } else {
-      nonimportantContests.push(new Contest(luck, important));
+      nonimportantContests.push(contest);
     }
   });
 
@@ -55,11 +63,11 @@ export function luckBalance(k, contests) {
   const cut = Math.min(k, size);
 
   for (let i = 0; i < cut; i++) {
-    total += importantContests[i].luck;
+    total += importantContests[i].getLuck();
   }
 
   for (let i = cut; i < size; i++) {
-    total -= importantContests[i].luck;
+    total -= importantContests[i].getLuck();
   }
 
   nonimportantContests.forEach((contest) => {