Merge pull request #662 from sir-gon/develop

Develop

Author: sir-gon

.gitignore

@@ -181,3 +181,6 @@ cython_debug/
 
 # Sarif
 *.sarif
+
+# SonarQube sonar-scanner (cli)
+.scannerwork

.pylintrc

@@ -552,7 +552,7 @@ const-naming-style=UPPER_CASE
 docstring-min-length=-1
 
 # Naming style matching correct function names.
-function-naming-style=snake_case
+function-naming-style=camelCase
 
 # Regular expression matching correct function names. Overrides function-
 # naming-style. If left empty, function names will be checked with the set

Makefile

@@ -118,15 +118,15 @@ upgrade:
 	${PACKAGE_TOOL} list --outdated | cut -f1 -d' ' | tr " " "\n" | awk '{if(NR>=3)print}' | cut -d' ' -f1 | xargs -n1 pip3 install -U
 
 clean:
-	${PACKAGE_TOOL} freeze > unins ; pip3 uninstall -y -r unins ; rm unins
+	${PACKAGE_TOOL} freeze > unins ; ${PACKAGE_TOOL} uninstall -y -r unins ; rm unins
 	rm -f .coverage
 	rm -fr .pytest_cache
 	rm -fr htmlcov
 	rm -fr coverage
 	rm -fr build
-	find . -path "*/*.pyc" -delete -print
-	find . -path "*/*.pyo" -delete -print
-	find . -path "*/__pycache__" -type d -print -exec rm -fr {} ';'
+	find . -path "*/*.pyc" -delete -print || true
+	find . -path "*/*.pyo" -delete -print || true
+	find . -path "*/__pycache__" -type d -print -exec rm -fr {} ';' || true
 
 compose/build: env
 	${DOCKER_COMPOSE} --profile lint build

docs/hackerrank/interview_preparation_kit/linked_lists/insert-a-node-into-a-sorted-doubly-linked-list.md

@@ -1,4 +1,4 @@
-# [Linked Lists: Insert a node at a specific position in a linked list](https://www.hackerrank.com/challenges/insert-a-node-at-a-specific-position-in-a-linked-list)
+# [Linked Lists: Insert a node at a specific position in a linked list](https://www.hackerrank.com/challenges/insert-a-node-into-a-sorted-doubly-linked-list)
 
 Create a node with a given value and insert it into a sorted doubly-linked list
 

sonar-project.properties

@@ -24,3 +24,4 @@ sonar.issue.ignore.multicriteria=e1
 # python:S6792 Use the "type" parameter syntax to declare this generic class.
 sonar.issue.ignore.multicriteria.e1.ruleKey=python:S6792
 sonar.issue.ignore.multicriteria.e1.resourceKey=**/*.py
+sonar.python.naming.function=^[a-z][a-zA-Z0-9]*$

src/hackerrank/implementation/between_two_sets.py

@@ -5,7 +5,7 @@
 LOGGER = logging.getLogger(__name__)
 
 
-def is_factor(_n: int, group: list[int]) -> bool:
+def isFactor(_n: int, group: list[int]) -> bool:
     result: bool = True
     i: int = 0
 
@@ -21,7 +21,7 @@ def is_factor(_n: int, group: list[int]) -> bool:
     return result
 
 
-def factor_of(_n: int, group: list[int]):
+def factorOf(_n: int, group: list[int]):
     result: bool = True
     i: int = 0
 
@@ -37,15 +37,15 @@ def factor_of(_n: int, group: list[int]):
     return result
 
 
-def get_total_x(_a: list[int], _b: list[int]) -> int:
+def getTotalX(_a: list[int], _b: list[int]) -> int:
     _max_ = 0
     for _, j in enumerate(_b):
         _max_ = max(_max_, j)
 
     result: list[int] = []
 
     for i in range(2, _max_):
-        if is_factor(i, _a) and factor_of(i, _b):
+        if isFactor(i, _a) and factorOf(i, _b):
             result.append(i)
 
     output = len(result)

src/hackerrank/implementation/between_two_sets_test.py

@@ -1,5 +1,5 @@
 import unittest
-from .between_two_sets import get_total_x, is_factor, factor_of
+from .between_two_sets import getTotalX, isFactor, factorOf
 
 
 class TestProblemBetweenTwoSets(unittest.TestCase):
@@ -9,39 +9,39 @@ def test_get_total_x(self):
         tinput: list[int] = [16, 32, 96]
         solution_found: int = 0
 
-        calculated_a = get_total_x([], tinput)
+        calculated_a = getTotalX([], tinput)
 
         self.assertEqual(
             calculated_a, solution_found,
-            f"get_total_x([], tinput) must be "
+            f"getTotalX([], tinput) must be "
             f"=> {solution_found}")
 
-        calculated_b = get_total_x(tinput, [])
+        calculated_b = getTotalX(tinput, [])
 
         self.assertEqual(
             calculated_b, solution_found,
-            f"get_total_x({tinput}, {[]}) must be "
+            f"getTotalX({tinput}, {[]}) must be "
             f"=> {solution_found}")
 
-        calculated_c = get_total_x([], [])
+        calculated_c = getTotalX([], [])
 
         self.assertEqual(
             calculated_c, solution_found,
-            f"get_total_x({[]}, {[]}) must be "
+            f"getTotalX({[]}, {[]}) must be "
             f"=> {solution_found}")
 
-        calculated_d = is_factor(1, [])
+        calculated_d = isFactor(1, [])
 
         self.assertEqual(
             calculated_d, solution_found,
-            f"is_factor({1}, {[]}) must be "
+            f"isFactor({1}, {[]}) must be "
             f"=> {False}")
 
-        calculated_e = factor_of(1, [])
+        calculated_e = factorOf(1, [])
 
         self.assertEqual(
             calculated_e, solution_found,
-            f"factor_of({1}, {[]}) must be "
+            f"factorOf({1}, {[]}) must be "
             f"=> {False}")
 
     def test_get_total_x_case_0(self):
@@ -53,11 +53,11 @@ def test_get_total_x_case_0(self):
         solution_found = 3
 
         self.assertEqual(
-            get_total_x(_a_, _b_), solution_found,
-            f"get_total_x({_a_}, {_b_}) must be "
+            getTotalX(_a_, _b_), solution_found,
+            f"getTotalX({_a_}, {_b_}) must be "
             f"=> {solution_found}")
 
         self.assertEqual(
-            get_total_x(_a_, _b_reverse_), solution_found,
-            f"get_total_x({_a_}, {_b_reverse_}) must be "
+            getTotalX(_a_, _b_reverse_), solution_found,
+            f"getTotalX({_a_}, {_b_reverse_}) must be "
             f"=> {solution_found}")

src/hackerrank/interview_preparation_kit/arrays/cruch_bruteforce.py

@@ -6,7 +6,7 @@
 LOGGER = logging.getLogger(__name__)
 
 
-def array_manipulation(n_operations: int, queries: list[list[int]]) -> int:
+def arrayManipulation(n_operations: int, queries: list[list[int]]) -> int:
     result = [0] * (n_operations + 1)
     maximum = 0
 

src/hackerrank/interview_preparation_kit/arrays/cruch_bruteforce_test.py

@@ -2,7 +2,7 @@
 from pathlib import Path
 
 from ....hackerrank.lib.loader import load_test_cases
-from .cruch_bruteforce import array_manipulation
+from .cruch_bruteforce import arrayManipulation
 
 FILE_PATH = str(Path(__file__).resolve().parent)
 
@@ -17,6 +17,6 @@ def test_array_manipulation(self):
         for _, _tt in enumerate(CRUCH_SMALL_TEST_CASES):
 
             self.assertEqual(
-                array_manipulation(_tt['n'], _tt['queries']), _tt['expected'],
-                f"{_} | array_manipulation({_tt['n']}, {_tt['queries']}) must be "
+                arrayManipulation(_tt['n'], _tt['queries']), _tt['expected'],
+                f"{_} | arrayManipulation({_tt['n']}, {_tt['queries']}) must be "
                 f"=> {_tt['expected']}")

src/hackerrank/interview_preparation_kit/arrays/cruch_optimized.py

@@ -9,7 +9,7 @@
 LOGGER = logging.getLogger(__name__)
 
 
-def array_manipulation_optimized(n_operations: int, queries: list[list[int]]) -> int:
+def arrayManipulation(n_operations: int, queries: list[list[int]]) -> int:
     # why adding 2?
     #   first slot to adjust 1-based index and
     #   last slot for storing accum_sum result

src/hackerrank/interview_preparation_kit/arrays/cruch_optimized_test.py

@@ -2,7 +2,7 @@
 from pathlib import Path
 
 from ....hackerrank.lib.loader import load_test_cases
-from .cruch_optimized import array_manipulation_optimized
+from .cruch_optimized import arrayManipulation
 
 FILE_PATH = str(Path(__file__).resolve().parent)
 
@@ -17,6 +17,6 @@ def test_array_manipulation_optimized(self):
         for _, _tt in enumerate(CRUCH_SMALL_TEST_CASES):
 
             self.assertEqual(
-                array_manipulation_optimized(_tt['n'], _tt['queries']), _tt['expected'],
+                arrayManipulation(_tt['n'], _tt['queries']), _tt['expected'],
                 f"{_} | array_manipulation_optimized({_tt['n']}, {_tt['queries']}) "
                 f"must be => {_tt['expected']}")

src/hackerrank/interview_preparation_kit/arrays/ctci_array_left_rotation.py

@@ -7,20 +7,20 @@
 FIRST_POSITION: int = 0
 
 
-def rot_left_one(group: list[int]) -> list[int]:
+def rotLeftOne(group: list[int]) -> list[int]:
 
     first = group.pop(FIRST_POSITION)
     group.append(first)
 
     return group
 
 
-def rot_left(group: list[int], d_rotations: int) -> list[int]:
+def rotLeft(group: list[int], d_rotations: int) -> list[int]:
 
     output = group.copy()
     i = 1
     while i <= d_rotations:
-        output = rot_left_one(output)
+        output = rotLeftOne(output)
         i += 1
 
     return output

src/hackerrank/interview_preparation_kit/arrays/ctci_array_left_rotation_test.py

@@ -2,7 +2,7 @@
 from pathlib import Path
 
 from ....hackerrank.lib.loader import load_test_cases
-from .ctci_array_left_rotation import rot_left, rot_left_one
+from .ctci_array_left_rotation import rotLeft, rotLeftOne
 
 FILE_PATH = str(Path(__file__).resolve().parent)
 
@@ -16,8 +16,8 @@ def test_rot_left_one(self):
         for _, _tt in enumerate(TEST_CASES):
 
             self.assertEqual(
-                rot_left_one(_tt['input']), _tt['expected'],
-                f"{_} | rot_left({_tt['input']}) must be "
+                rotLeftOne(_tt['input']), _tt['expected'],
+                f"{_} | rotLeftOne({_tt['input']}) must be "
                 f"=> {_tt['expected']}")
 
     def test_rot_left(self):
@@ -29,6 +29,6 @@ def test_rot_left(self):
         for _, _tt in enumerate(tests):
 
             self.assertEqual(
-                rot_left(_tt['input'], _tt['d']), _tt['expected'],
-                f"{_} | rot_left({_tt['input']}) must be "
+                rotLeft(_tt['input'], _tt['d']), _tt['expected'],
+                f"{_} | rotLeft({_tt['input']}) must be "
                 f"=> {_tt['expected']}")

src/hackerrank/interview_preparation_kit/arrays/minimum_swaps_2.py

@@ -6,7 +6,7 @@
 LOGGER = logging.getLogger(__name__)
 
 
-def minimum_swaps(group: list[int]) -> int:
+def minimumSwaps(group: list[int]) -> int:
     indexed_group = [i - 1 for i in group]
 
     swaps = 0

src/hackerrank/interview_preparation_kit/arrays/minimum_swaps_2_test.py

@@ -2,7 +2,7 @@
 from pathlib import Path
 
 from ....hackerrank.lib.loader import load_test_cases
-from .minimum_swaps_2 import minimum_swaps
+from .minimum_swaps_2 import minimumSwaps
 
 FILE_PATH = str(Path(__file__).resolve().parent)
 
@@ -17,6 +17,6 @@ def test_minimum_swaps(self):
         for _, _tt in enumerate(TEST_CASES):
 
             self.assertEqual(
-                minimum_swaps(_tt['input']), _tt['expected'],
-                f"{_} | minimum_swaps({_tt['input']}) must be "
+                minimumSwaps(_tt['input']), _tt['expected'],
+                f"{_} | minimumSwaps({_tt['input']}) must be "
                 f"=> {_tt['expected']}")

src/hackerrank/interview_preparation_kit/arrays/new_year_chaos.py

@@ -4,11 +4,10 @@
 import logging
 
 LOGGER = logging.getLogger(__name__)
-
 TOO_CHAOTIC_ERROR = 'Too chaotic'
 
 
-def minimum_bribes(queue: list[int]) -> 'int | None':
+def minimumBribesCompute(queue: list[int]) -> 'int | None':
     bribes = 0
 
     for i, value in enumerate(queue):
@@ -24,10 +23,14 @@ def minimum_bribes(queue: list[int]) -> 'int | None':
     return bribes
 
 
-def minimum_bribes_transform(queue: list[int]) -> 'int | str':
+def minimumBribesText(queue: list[int]) -> 'int | str':
 
-    result = minimum_bribes(queue)
+    result = minimumBribesCompute(queue)
     if result is None:
         return TOO_CHAOTIC_ERROR
 
     return result
+
+
+def minimumBribes(queue: list[int]):
+    print(minimumBribesText(queue))

src/hackerrank/interview_preparation_kit/arrays/new_year_chaos_test.py

@@ -2,7 +2,7 @@
 from pathlib import Path
 
 from ....hackerrank.lib.loader import load_test_cases
-from .new_year_chaos import minimum_bribes_transform
+from .new_year_chaos import minimumBribes, minimumBribesText
 
 FILE_PATH = str(Path(__file__).resolve().parent)
 
@@ -17,6 +17,8 @@ def test_minimum_bribes(self):
         for _, _tt in enumerate(TEST_CASES):
 
             self.assertEqual(
-                minimum_bribes_transform(_tt['input']), _tt['expected'],
-                f"{_} | minimum_bribes_transform({_tt['input']}) must be "
+                minimumBribesText(_tt['input']), _tt['expected'],
+                f"{_} | minimumBribesText({_tt['input']}) must be "
                 f"=> {_tt['expected']}")
+
+            minimumBribes(_tt['input'])  # Print the result (for coverage)

src/hackerrank/interview_preparation_kit/arrays/two_d_array.py

@@ -25,7 +25,7 @@ def gethourglass(arr: list[list[int]], position_x: int, position_y: int) -> list
     return result
 
 
-def hourglass_sum(arr: list[list[int]]) -> int | None:
+def hourglassSum(arr: list[list[int]]) -> int | None:
     matrix_size: int = len(arr)
 
     matrix_start_index: int = 1

src/hackerrank/interview_preparation_kit/arrays/two_d_array_test.py

@@ -2,7 +2,7 @@
 from pathlib import Path
 
 from ....hackerrank.lib.loader import load_test_cases
-from .two_d_array import hourglass_sum
+from .two_d_array import hourglassSum
 
 FILE_PATH = str(Path(__file__).resolve().parent)
 
@@ -16,6 +16,6 @@ def test_hourglass_sum(self):
         for _, _tt in enumerate(TEST_CASES):
 
             self.assertEqual(
-                hourglass_sum(_tt['input']), _tt['expected'],
-                f"{_} | hourglass_sum({_tt['input']}) must be "
+                hourglassSum(_tt['input']), _tt['expected'],
+                f"{_} | hourglassSum({_tt['input']}) must be "
                 f"=> {_tt['expected']}")

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/count_triplets_1.py

@@ -4,7 +4,7 @@
 from collections import Counter
 
 
-def count_triplets_brute_force(arr: list[int], ratio: int) -> int:
+def countTripletsBruteForce(arr: list[int], ratio: int) -> int:
 
     size = len(arr)
     counter = 0
@@ -20,7 +20,7 @@ def count_triplets_brute_force(arr: list[int], ratio: int) -> int:
     return counter
 
 
-def count_triplets(arr: list[int], ratio: int) -> int:
+def countTriplets(arr: list[int], ratio: int) -> int:
     a_counter = Counter(arr)
     b_counter = Counter()
     triplets = 0