Merge pull request #544 from sir-gon/develop

Develop

Author: sir-gon

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/frequency_queries.py

@@ -3,6 +3,15 @@
 
 from typing import Dict
 
+__INITIAL__ = 0
+
+__INSERT__ = 1
+__DELETE__ = 2
+__SELECT__ = 3
+
+__NOT_FOUND__ = 0
+__FOUND__ = 1
+
 
 def freq_query(queries):
     result = []
@@ -11,18 +20,19 @@ def freq_query(queries):
     for query in queries:
         operation = query[0]
         data = query[1]
+        current = data_map.get(data, __INITIAL__)
 
-        if operation == 1:  # insert
-            data_map[data] = data_map.get(data, 0) + 1
-        elif operation == 2 and data_map.get(data, 0) > 0:  # delete
-            data_map[data] -= 1
-        elif operation == 3:  # "select"
+        if operation == __INSERT__:
+            data_map[data] = current + 1
+        elif operation == __DELETE__:
+            data_map[data] = max(current - 1, 0)
+        elif operation == __SELECT__:
             for value in data_map.values():
                 if value == data:
-                    result.append(1)
+                    result.append(__FOUND__)
                     break
             else:
-                result.append(0)
+                result.append(__NOT_FOUND__)
         else:
             raise ValueError('Invalid operation')
 

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/frequency_queries_test.py

@@ -15,7 +15,75 @@
             [2, 5],
             [3, 2]
         ],
-        'answer': [0, 1]
+        'expected': [0, 1]
+    },
+    {
+        'title': 'Sample Test Case 2',
+        'input': [
+            [1, 3],
+            [2, 3],
+            [3, 2],
+            [1, 4],
+            [1, 5],
+            [1, 5],
+            [1, 4],
+            [3, 2],
+            [2, 4],
+            [3, 2]
+        ],
+        'expected': [0, 1, 1]
+    },
+    {
+        'title': 'Sample Test Case 3',
+        'input': [
+            [1, 3],
+            [1, 38],
+            [2, 1],
+            [1, 16],
+            [2, 1],
+            [2, 2],
+            [1, 64],
+            [1, 84],
+            [3, 1],
+            [1, 100],
+            [1, 10],
+            [2, 2],
+            [2, 1],
+            [1, 67],
+            [2, 2],
+            [3, 1],
+            [1, 99],
+            [1, 32],
+            [1, 58],
+            [3, 2]
+        ],
+        'expected': [1, 1, 0]
+    },
+    {
+        'title': 'Sample Test Case 3',
+        'input': [
+            [1, 3],
+            [1, 38],
+            [2, 1],
+            [1, 16],
+            [2, 1],
+            [2, 2],
+            [1, 64],
+            [1, 84],
+            [3, 1],
+            [1, 100],
+            [1, 10],
+            [2, 2],
+            [2, 1],
+            [1, 67],
+            [2, 2],
+            [3, 1],
+            [1, 99],
+            [1, 32],
+            [1, 58],
+            [3, 2]
+        ],
+        'expected': [1, 1, 0]
     }
 ]
 
@@ -27,9 +95,9 @@ def test_freq_query(self):
         for _, _tt in enumerate(TEST_CASES):
 
             self.assertEqual(
-                freq_query(_tt['input']), _tt['answer'],
+                freq_query(_tt['input']), _tt['expected'],
                 f"{_} | freq_query({_tt['input']}) must be "
-                f"=> {_tt['answer']}")
+                f"=> {_tt['expected']}")
 
     def test_freq_query_edge_case(self):