Merge pull request #234 from sir-gon/sonarlint

[REFACTOR] sonarlint fixes

Author: sir-gon

Dockerfile

@@ -1,9 +1,9 @@
-FROM python:3.11.3-alpine3.16 as base
+FROM python:3.11.3-alpine3.16 AS base
 
 ENV WORKDIR=/app
 WORKDIR ${WORKDIR}
 
-FROM node:20.2.0-alpine3.16 as lint
+FROM node:20.2.0-alpine3.16 AS lint
 
 ENV WORKDIR=/app
 WORKDIR ${WORKDIR}
@@ -15,11 +15,11 @@ RUN npm install -g markdownlint-cli
 RUN apk add --update --no-cache nodejs npm
 RUN npm install -g pyright
 
-FROM base as development
+FROM base AS development
 
 RUN apk add --update --no-cache make
 
-FROM development as builder
+FROM development AS builder
 
 COPY ./src ${WORKDIR}/src
 COPY ./requirements.txt ${WORKDIR}/
@@ -34,7 +34,7 @@ RUN pip install -r requirements.txt
 ##
 ## https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions
 ##
-FROM builder as testing
+FROM builder AS testing
 
 ENV LOG_LEVEL=INFO
 ENV BRUTEFORCE=false
@@ -51,7 +51,7 @@ CMD ["make", "test", "-e", "{DEBUG}"]
 ## in the production phase, "good practices" such as
 ## WORKSPACE and USER are maintained
 ##
-FROM builder as production
+FROM builder AS production
 
 ENV LOG_LEVEL=INFO
 ENV BRUTEFORCE=false

src/projecteuler/helpers/matrix.py

@@ -5,6 +5,6 @@
 def matrix(t_n: int, t_m: int, init: int | None) -> List[List[int]]:
     result = []
 
-    for i in range(0, t_n):
-        result.append([init for i in range(t_m)])
+    for _ in range(0, t_n):
+        result.append([init for _ in range(t_m)])
     return result

src/projecteuler/lib/binary_node_builder.py

@@ -65,9 +65,8 @@ def build_binary_node_tree_weigth(
                     )
                 )
 
-            if result_node.is_leaf():
-                if leaves_collector is not None:
-                    leaves_collector.append(current_value)
+            if result_node.is_leaf() and leaves_collector is not None:
+                leaves_collector.append(current_value)
 
             return result_node