Skip to content

Commit b980ae9

Browse files
author
Gonzalo Diaz
committed
[REFACTOR] Fixing naming convention for function names (to match with Hacker Rank interface).
1 parent 26b4a14 commit b980ae9

File tree

66 files changed

+210
-196
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+210
-196
lines changed

docs/hackerrank/interview_preparation_kit/linked_lists/insert-a-node-into-a-sorted-doubly-linked-list.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# [Linked Lists: Insert a node at a specific position in a linked list](https://www.hackerrank.com/challenges/insert-a-node-at-a-specific-position-in-a-linked-list)
1+
# [Linked Lists: Insert a node at a specific position in a linked list](https://www.hackerrank.com/challenges/insert-a-node-into-a-sorted-doubly-linked-list)
22

33
Create a node with a given value and insert it into a sorted doubly-linked list
44

src/hackerrank/interview_preparation_kit/arrays/cruch_bruteforce.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
LOGGER = logging.getLogger(__name__)
77

88

9-
def array_manipulation(n_operations: int, queries: list[list[int]]) -> int:
9+
def arrayManipulation(n_operations: int, queries: list[list[int]]) -> int:
1010
result = [0] * (n_operations + 1)
1111
maximum = 0
1212

src/hackerrank/interview_preparation_kit/arrays/cruch_bruteforce_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from pathlib import Path
33

44
from ....hackerrank.lib.loader import load_test_cases
5-
from .cruch_bruteforce import array_manipulation
5+
from .cruch_bruteforce import arrayManipulation
66

77
FILE_PATH = str(Path(__file__).resolve().parent)
88

@@ -17,6 +17,6 @@ def test_array_manipulation(self):
1717
for _, _tt in enumerate(CRUCH_SMALL_TEST_CASES):
1818

1919
self.assertEqual(
20-
array_manipulation(_tt['n'], _tt['queries']), _tt['expected'],
21-
f"{_} | array_manipulation({_tt['n']}, {_tt['queries']}) must be "
20+
arrayManipulation(_tt['n'], _tt['queries']), _tt['expected'],
21+
f"{_} | arrayManipulation({_tt['n']}, {_tt['queries']}) must be "
2222
f"=> {_tt['expected']}")

src/hackerrank/interview_preparation_kit/arrays/cruch_optimized.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
LOGGER = logging.getLogger(__name__)
1010

1111

12-
def array_manipulation_optimized(n_operations: int, queries: list[list[int]]) -> int:
12+
def arrayManipulation(n_operations: int, queries: list[list[int]]) -> int:
1313
# why adding 2?
1414
# first slot to adjust 1-based index and
1515
# last slot for storing accum_sum result

src/hackerrank/interview_preparation_kit/arrays/cruch_optimized_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from pathlib import Path
33

44
from ....hackerrank.lib.loader import load_test_cases
5-
from .cruch_optimized import array_manipulation_optimized
5+
from .cruch_optimized import arrayManipulation
66

77
FILE_PATH = str(Path(__file__).resolve().parent)
88

@@ -17,6 +17,6 @@ def test_array_manipulation_optimized(self):
1717
for _, _tt in enumerate(CRUCH_SMALL_TEST_CASES):
1818

1919
self.assertEqual(
20-
array_manipulation_optimized(_tt['n'], _tt['queries']), _tt['expected'],
20+
arrayManipulation(_tt['n'], _tt['queries']), _tt['expected'],
2121
f"{_} | array_manipulation_optimized({_tt['n']}, {_tt['queries']}) "
2222
f"must be => {_tt['expected']}")

src/hackerrank/interview_preparation_kit/arrays/ctci_array_left_rotation.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,20 @@
77
FIRST_POSITION: int = 0
88

99

10-
def rot_left_one(group: list[int]) -> list[int]:
10+
def rotLeftOne(group: list[int]) -> list[int]:
1111

1212
first = group.pop(FIRST_POSITION)
1313
group.append(first)
1414

1515
return group
1616

1717

18-
def rot_left(group: list[int], d_rotations: int) -> list[int]:
18+
def rotLeft(group: list[int], d_rotations: int) -> list[int]:
1919

2020
output = group.copy()
2121
i = 1
2222
while i <= d_rotations:
23-
output = rot_left_one(output)
23+
output = rotLeftOne(output)
2424
i += 1
2525

2626
return output

src/hackerrank/interview_preparation_kit/arrays/ctci_array_left_rotation_test.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from pathlib import Path
33

44
from ....hackerrank.lib.loader import load_test_cases
5-
from .ctci_array_left_rotation import rot_left, rot_left_one
5+
from .ctci_array_left_rotation import rotLeft, rotLeftOne
66

77
FILE_PATH = str(Path(__file__).resolve().parent)
88

@@ -16,8 +16,8 @@ def test_rot_left_one(self):
1616
for _, _tt in enumerate(TEST_CASES):
1717

1818
self.assertEqual(
19-
rot_left_one(_tt['input']), _tt['expected'],
20-
f"{_} | rot_left({_tt['input']}) must be "
19+
rotLeftOne(_tt['input']), _tt['expected'],
20+
f"{_} | rotLeftOne({_tt['input']}) must be "
2121
f"=> {_tt['expected']}")
2222

2323
def test_rot_left(self):
@@ -29,6 +29,6 @@ def test_rot_left(self):
2929
for _, _tt in enumerate(tests):
3030

3131
self.assertEqual(
32-
rot_left(_tt['input'], _tt['d']), _tt['expected'],
33-
f"{_} | rot_left({_tt['input']}) must be "
32+
rotLeft(_tt['input'], _tt['d']), _tt['expected'],
33+
f"{_} | rotLeft({_tt['input']}) must be "
3434
f"=> {_tt['expected']}")

src/hackerrank/interview_preparation_kit/arrays/minimum_swaps_2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
LOGGER = logging.getLogger(__name__)
77

88

9-
def minimum_swaps(group: list[int]) -> int:
9+
def minimumSwaps(group: list[int]) -> int:
1010
indexed_group = [i - 1 for i in group]
1111

1212
swaps = 0

src/hackerrank/interview_preparation_kit/arrays/minimum_swaps_2_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from pathlib import Path
33

44
from ....hackerrank.lib.loader import load_test_cases
5-
from .minimum_swaps_2 import minimum_swaps
5+
from .minimum_swaps_2 import minimumSwaps
66

77
FILE_PATH = str(Path(__file__).resolve().parent)
88

@@ -17,6 +17,6 @@ def test_minimum_swaps(self):
1717
for _, _tt in enumerate(TEST_CASES):
1818

1919
self.assertEqual(
20-
minimum_swaps(_tt['input']), _tt['expected'],
21-
f"{_} | minimum_swaps({_tt['input']}) must be "
20+
minimumSwaps(_tt['input']), _tt['expected'],
21+
f"{_} | minimumSwaps({_tt['input']}) must be "
2222
f"=> {_tt['expected']}")

src/hackerrank/interview_preparation_kit/arrays/new_year_chaos.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@
44
import logging
55

66
LOGGER = logging.getLogger(__name__)
7-
87
TOO_CHAOTIC_ERROR = 'Too chaotic'
98

109

11-
def minimum_bribes(queue: list[int]) -> 'int | None':
10+
def minimumBribesCompute(queue: list[int]) -> 'int | None':
1211
bribes = 0
1312

1413
for i, value in enumerate(queue):
@@ -24,10 +23,14 @@ def minimum_bribes(queue: list[int]) -> 'int | None':
2423
return bribes
2524

2625

27-
def minimum_bribes_transform(queue: list[int]) -> 'int | str':
26+
def minimumBribesText(queue: list[int]) -> 'int | str':
2827

29-
result = minimum_bribes(queue)
28+
result = minimumBribesCompute(queue)
3029
if result is None:
3130
return TOO_CHAOTIC_ERROR
3231

3332
return result
33+
34+
35+
def minimumBribes(queue: list[int]):
36+
print(minimumBribesText(queue))

src/hackerrank/interview_preparation_kit/arrays/new_year_chaos_test.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from pathlib import Path
33

44
from ....hackerrank.lib.loader import load_test_cases
5-
from .new_year_chaos import minimum_bribes_transform
5+
from .new_year_chaos import minimumBribes, minimumBribesText
66

77
FILE_PATH = str(Path(__file__).resolve().parent)
88

@@ -17,6 +17,8 @@ def test_minimum_bribes(self):
1717
for _, _tt in enumerate(TEST_CASES):
1818

1919
self.assertEqual(
20-
minimum_bribes_transform(_tt['input']), _tt['expected'],
21-
f"{_} | minimum_bribes_transform({_tt['input']}) must be "
20+
minimumBribesText(_tt['input']), _tt['expected'],
21+
f"{_} | minimumBribesText({_tt['input']}) must be "
2222
f"=> {_tt['expected']}")
23+
24+
minimumBribes(_tt['input']) # Print the result (for coverage)

src/hackerrank/interview_preparation_kit/arrays/two_d_array.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def gethourglass(arr: list[list[int]], position_x: int, position_y: int) -> list
2525
return result
2626

2727

28-
def hourglass_sum(arr: list[list[int]]) -> int | None:
28+
def hourglassSum(arr: list[list[int]]) -> int | None:
2929
matrix_size: int = len(arr)
3030

3131
matrix_start_index: int = 1

src/hackerrank/interview_preparation_kit/arrays/two_d_array_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from pathlib import Path
33

44
from ....hackerrank.lib.loader import load_test_cases
5-
from .two_d_array import hourglass_sum
5+
from .two_d_array import hourglassSum
66

77
FILE_PATH = str(Path(__file__).resolve().parent)
88

@@ -16,6 +16,6 @@ def test_hourglass_sum(self):
1616
for _, _tt in enumerate(TEST_CASES):
1717

1818
self.assertEqual(
19-
hourglass_sum(_tt['input']), _tt['expected'],
20-
f"{_} | hourglass_sum({_tt['input']}) must be "
19+
hourglassSum(_tt['input']), _tt['expected'],
20+
f"{_} | hourglassSum({_tt['input']}) must be "
2121
f"=> {_tt['expected']}")

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/count_triplets_1.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from collections import Counter
55

66

7-
def count_triplets_brute_force(arr: list[int], ratio: int) -> int:
7+
def countTripletsBruteForce(arr: list[int], ratio: int) -> int:
88

99
size = len(arr)
1010
counter = 0
@@ -20,7 +20,7 @@ def count_triplets_brute_force(arr: list[int], ratio: int) -> int:
2020
return counter
2121

2222

23-
def count_triplets(arr: list[int], ratio: int) -> int:
23+
def countTriplets(arr: list[int], ratio: int) -> int:
2424
a_counter = Counter(arr)
2525
b_counter = Counter()
2626
triplets = 0

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/count_triplets_1_test.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from pathlib import Path
33

44
from ....hackerrank.lib.loader import load_test_cases
5-
from .count_triplets_1 import count_triplets, count_triplets_brute_force
5+
from .count_triplets_1 import countTriplets, countTripletsBruteForce
66

77
FILE_PATH = str(Path(__file__).resolve().parent)
88

@@ -19,7 +19,7 @@ def test_count_triplets_brute_force(self):
1919
for _, _tt in enumerate(SMALL_TEST_CASES):
2020

2121
self.assertEqual(
22-
count_triplets_brute_force(_tt['input'], _tt['r']), _tt['expected'],
22+
countTripletsBruteForce(_tt['input'], _tt['r']), _tt['expected'],
2323
f"{_} | count_triplets_brute_force({_tt['input']}, {_tt['r']}) must be "
2424
f"=> {_tt['expected']}")
2525

@@ -28,7 +28,7 @@ def test_count_triplets(self):
2828
for _, _tt in enumerate(SMALL_TEST_CASES):
2929

3030
self.assertEqual(
31-
count_triplets(_tt['input'], _tt['r']), _tt['expected'],
31+
countTriplets(_tt['input'], _tt['r']), _tt['expected'],
3232
f"{_} | count_triplets({_tt['input']}, {_tt['r']}) must be "
3333
f"=> {_tt['expected']} in {_tt['title']}")
3434

@@ -37,6 +37,6 @@ def test_count_triplets_big_cases(self):
3737
for _, _tt in enumerate(TEST_CASES_BIG):
3838

3939
self.assertEqual(
40-
count_triplets(_tt['input'], _tt['r']), _tt['expected'],
40+
countTriplets(_tt['input'], _tt['r']), _tt['expected'],
4141
f"{_} | count_triplets({_tt['input']}, {_tt['r']}) must be "
4242
f"=> {_tt['expected']} in {_tt['title']}")

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/ctci_ransom_note.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
__NO__ = 'No'
88

99

10-
def check_magazine_compute(magazine: List[str], note: List[str]) -> bool:
10+
def checkMagazineCompute(magazine: List[str], note: List[str]) -> bool:
1111
dictionary: Dict[str, int] = {}
1212

1313
word: str
@@ -29,5 +29,9 @@ def check_magazine_compute(magazine: List[str], note: List[str]) -> bool:
2929
return True
3030

3131

32-
def check_magazine(magazine: List[str], note: List[str]) -> str:
33-
return __YES__ if check_magazine_compute(magazine, note) else __NO__
32+
def checkMagazineText(magazine: List[str], note: List[str]) -> str:
33+
return __YES__ if checkMagazineCompute(magazine, note) else __NO__
34+
35+
36+
def checkMagazine(magazine: List[str], note: List[str]):
37+
print(checkMagazineText(magazine, note))

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/ctci_ransom_note_test.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from pathlib import Path
33

44
from ....hackerrank.lib.loader import load_test_cases
5-
from .ctci_ransom_note import check_magazine
5+
from .ctci_ransom_note import checkMagazine, checkMagazineText
66

77
FILE_PATH = str(Path(__file__).resolve().parent)
88

@@ -17,6 +17,9 @@ def test_check_magazine(self):
1717
for _, _tt in enumerate(TEST_CASES):
1818

1919
self.assertEqual(
20-
check_magazine(_tt['magazine'], _tt['note']), _tt['expected'],
21-
f"{_} | check_magazine({_tt['magazine']}, {_tt['note']}) must be "
20+
checkMagazineText(_tt['magazine'], _tt['note']), _tt['expected'],
21+
f"{_} | checkMagazineText({_tt['magazine']}, {_tt['note']}) must be "
2222
f"=> {_tt['expected']}")
23+
24+
# Print the result (for coverage)
25+
checkMagazine(_tt['magazine'], _tt['note'])

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/frequency_queries.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
__FOUND__ = 1
1414

1515

16-
def freq_query(queries):
16+
def freqQuery(queries):
1717
result = []
1818
data_map: Dict[int, int] = {}
1919

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/frequency_queries_test.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from pathlib import Path
33

44
from ....hackerrank.lib.loader import load_test_cases
5-
from .frequency_queries import freq_query
5+
from .frequency_queries import freqQuery
66

77
FILE_PATH = str(Path(__file__).resolve().parent)
88

@@ -17,12 +17,12 @@ def test_freq_query(self):
1717
for _, _tt in enumerate(TEST_CASES):
1818

1919
self.assertEqual(
20-
freq_query(_tt['input']), _tt['expected'],
21-
f"{_} | freq_query({_tt['input']}) must be "
20+
freqQuery(_tt['input']), _tt['expected'],
21+
f"{_} | freqQuery({_tt['input']}) must be "
2222
f"=> {_tt['expected']}")
2323

2424
def test_freq_query_edge_case(self):
2525

2626
self.assertRaisesRegex(ValueError,
2727
'Invalid operation',
28-
freq_query, [[4, 1]])
28+
freqQuery, [[4, 1]])

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/sherlock_and_anagrams.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
LOGGER = logging.getLogger(__name__)
1010

1111

12-
def sherlock_and_anagrams(s_word: str) -> int:
12+
def sherlockAndAnagrams(s_word: str) -> int:
1313

1414
candidates: Dict[str, List[str]] = {}
1515
size: int = len(s_word)

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/sherlock_and_anagrams_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import json
33
from pathlib import Path
44

5-
from .sherlock_and_anagrams import sherlock_and_anagrams
5+
from .sherlock_and_anagrams import sherlockAndAnagrams
66

77
FILE_PATH = str(Path(__file__).resolve().parent)
88
JSON_DATA_FILE = FILE_PATH + '/sherlock_and_anagrams.json'
@@ -19,6 +19,6 @@ def test_sherlock_and_anagrams(self):
1919
for _, _tt in enumerate(testset['tests']):
2020

2121
self.assertEqual(
22-
sherlock_and_anagrams(_tt['input']), _tt['expected'],
22+
sherlockAndAnagrams(_tt['input']), _tt['expected'],
2323
f"{_} | sherlock_and_anagrams({_tt['input']}) must be "
2424
f"=> {_tt['expected']}")

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/two_strings.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
__NO__ = 'No'
66

77

8-
def two_strings_compute(s1_word: str, s2_word: str) -> bool:
8+
def twoStringsCompute(s1_word: str, s2_word: str) -> bool:
99
for letter in s1_word:
1010
if letter in s2_word:
1111
return True
1212

1313
return False
1414

1515

16-
def two_strings(s1_word: str, s2_word: str) -> str:
17-
return __YES__ if two_strings_compute(s1_word, s2_word) else __NO__
16+
def twoStrings(s1_word: str, s2_word: str) -> str:
17+
return __YES__ if twoStringsCompute(s1_word, s2_word) else __NO__

0 commit comments

Comments
 (0)