[REFACTOR] [Hacker Rank] Interview Preparation Kit: String Manipulation: Sherlock and the Valid String. JSON data load for unit tests.

Author: Gonzalo Diaz

src/hackerrank/interview_preparation_kit/string_manipulation/sherlock_and_valid_string.testcases.json

@@ -0,0 +1,47 @@
+[
+  {
+    "title": "counterexample",
+    "input": "aabbccc",
+    "expected": true
+  },
+  {
+    "title": "counterexample",
+    "input": "a",
+    "expected": true
+  },
+  {
+    "title": "counterexample",
+    "input": "aaa",
+    "expected": true
+  },
+  {
+    "title": "counterexample",
+    "input": "abbccc",
+    "expected": false
+  },
+  {
+    "title": "counterexample",
+    "input": "bbccc",
+    "expected": false
+  },
+  {
+    "title": "Sample Test case 0",
+    "input": "aabbcd",
+    "expected": false
+  },
+  {
+    "title": "Sample Test case 1",
+    "input": "aabbccddeefghi",
+    "expected": false
+  },
+  {
+    "title": "Sample Test case 2",
+    "input": "abcdefghhgfedecba",
+    "expected": true
+  },
+  {
+    "title": "Sample Test case 4",
+    "input": "aabbc",
+    "expected": true
+  }
+]

src/hackerrank/interview_preparation_kit/string_manipulation/sherlock_and_valid_string_test.py

@@ -1,53 +1,12 @@
 import unittest
+from pathlib import Path
+
+from ....hackerrank.lib.loader import load_test_cases
 from .sherlock_and_valid_string import is_valid
 
-TEST_CASES = [
-    {
-        'title': 'counterexample',
-        'input': 'aabbccc',
-        'answer': True
-    },
-    {
-        'title': 'counterexample',
-        'input': 'a',
-        'answer': True
-    },
-    {
-        'title': 'counterexample',
-        'input': 'aaa',
-        'answer': True
-    },
-    {
-        'title': 'counterexample',
-        'input': 'abbccc',
-        'answer': False
-    },
-    {
-        'title': 'counterexample',
-        'input': 'bbccc',
-        'answer': False
-    },
-    {
-        'title': 'Sample Test case 0',
-        'input': 'aabbcd',
-        'answer': False
-    },
-    {
-        'title': 'Sample Test case 1',
-        'input': 'aabbccddeefghi',
-        'answer': False
-    },
-    {
-        'title': 'Sample Test case 2',
-        'input': 'abcdefghhgfedecba',
-        'answer': True
-    },
-    {
-        'title': 'Sample Test case 4',
-        'input': 'aabbc',
-        'answer': True
-    }
-]
+FILE_PATH = str(Path(__file__).resolve().parent)
+
+TEST_CASES = load_test_cases(FILE_PATH + '/sherlock_and_valid_string.testcases.json')
 
 
 class TestSherklockAndValidString(unittest.TestCase):
@@ -57,6 +16,6 @@ def test_is_valid(self):
         for _, _tt in enumerate(TEST_CASES):
 
             self.assertEqual(
-                is_valid(_tt['input']), _tt['answer'],
+                is_valid(_tt['input']), _tt['expected'],
                 f"{_} | is_valid({_tt['input']}) must be "
-                f"=> {_tt['answer']}")
+                f"=> {_tt['expected']}")