Got rid of the ViewData["dtgePreview"] option

Reverted back to using the querystring exclusively.

Author: leekelleher

docs/developers-guide.md

@@ -139,11 +139,11 @@ Because we treat your data as a standard `IPublishedContent` entity, that means
 
 #### Rendering Alternative Preview Content
 
-If your front end view is rather complex, you may decide that you want to feed the back office preview an alternative, less complex view. To do this, within your Razor view/partial, check `ViewData["dtgePreview"]` is set to true to detect being in preview mode to provide an alternative view.
+If your front end view is rather complex, you may decide that you want to feed the back office preview an alternative, less complex view. To do this, within your Razor view/partial, check for a querystring parameter `dtgePreview` being set to "1" to detect being in preview mode to provide an alternative view.
 
 ```
 @inherits Umbraco.Web.Mvc.UmbracoViewPage
-@if (ViewData["dtgePreview"] == true)
+@if (Request.QueryString["dtgePreview"] == "1")
 {
 	// Render preview view
 }

src/Our.Umbraco.DocTypeGridEditor/Web/Controllers/DocTypeGridEditorSurfaceController.cs

@@ -50,8 +50,6 @@ protected PartialViewResult CurrentPartialView(object model = null)
 
         protected override PartialViewResult PartialView(string viewName, object model)
         {
-            ViewData.Add("dtgePreview", IsPreview);
-
             if (IsPreview && string.IsNullOrWhiteSpace(PreviewViewPath) == false)
             {
                 var previewViewPath = GetFullViewPath(viewName, PreviewViewPath);

src/Our.Umbraco.DocTypeGridEditor/Web/Extensions/HtmlHelperExtensions.cs

@@ -1,7 +1,6 @@
 using System.Web;
 using System.Web.Mvc;
 using System.Web.Mvc.Html;
-using Our.Umbraco.DocTypeGridEditor.Extensions;
 using Our.Umbraco.DocTypeGridEditor.Web.Helpers;
 using Our.Umbraco.DocTypeGridEditor.Web.Mvc;
 using Umbraco.Core;
@@ -51,8 +50,6 @@ public static HtmlString RenderDocTypeGridEditorItem(
                 dtgePreview = isPreview
             };
 
-            var viewData = new ViewDataDictionary() { { "dtgePreview", isPreview } };
-
             // Try looking for surface controller with action named after the editor alias
             if (string.IsNullOrWhiteSpace(editorAlias) == false && SurfaceControllerHelper.SurfaceControllerExists(controllerName, editorAlias, true))
             {
@@ -93,19 +90,19 @@ public static HtmlString RenderDocTypeGridEditorItem(
                 var fullPreviewViewPath = $"{previewViewPath}{editorAlias}.cshtml";
                 if (ViewHelper.ViewExists(helper.ViewContext, fullPreviewViewPath, true))
                 {
-                    return helper.Partial(fullPreviewViewPath, content, viewData);
+                    return helper.Partial(fullPreviewViewPath, content);
                 }
 
                 fullPreviewViewPath = $"{previewViewPath}{content.DocumentTypeAlias}.cshtml";
                 if (ViewHelper.ViewExists(helper.ViewContext, fullPreviewViewPath, true))
                 {
-                    return helper.Partial(fullPreviewViewPath, content, viewData);
+                    return helper.Partial(fullPreviewViewPath, content);
                 }
 
                 fullPreviewViewPath = $"{previewViewPath}Default.cshtml";
                 if (ViewHelper.ViewExists(helper.ViewContext, fullPreviewViewPath, true))
                 {
-                    return helper.Partial(fullPreviewViewPath, content, viewData);
+                    return helper.Partial(fullPreviewViewPath, content);
                 }
             }
 
@@ -115,29 +112,29 @@ public static HtmlString RenderDocTypeGridEditorItem(
                 var fullViewPath = $"{viewPath}{editorAlias}.cshtml";
                 if (ViewHelper.ViewExists(helper.ViewContext, fullViewPath, true))
                 {
-                    return helper.Partial(fullViewPath, content, viewData);
+                    return helper.Partial(fullViewPath, content);
                 }
 
                 fullViewPath = $"{viewPath}{content.DocumentTypeAlias}.cshtml";
                 if (ViewHelper.ViewExists(helper.ViewContext, fullViewPath, true))
                 {
-                    return helper.Partial(fullViewPath, content, viewData);
+                    return helper.Partial(fullViewPath, content);
                 }
 
                 fullViewPath = $"{viewPath}Default.cshtml";
                 if (ViewHelper.ViewExists(helper.ViewContext, fullViewPath, true))
                 {
-                    return helper.Partial(fullViewPath, content, viewData);
+                    return helper.Partial(fullViewPath, content);
                 }
             }
 
             // Resort to standard partial views
             if (ViewHelper.ViewExists(helper.ViewContext, editorAlias, true))
             {
-                return helper.Partial(editorAlias, content, viewData);
+                return helper.Partial(editorAlias, content);
             }
 
-            return helper.Partial(content.DocumentTypeAlias, content, viewData);
+            return helper.Partial(content.DocumentTypeAlias, content);
         }
     }
 }