Skip to content

Commit 7876032

Browse files
committed
UseSpacingSniff: Fixed internal errors
1 parent 9704d3b commit 7876032

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

SlevomatCodingStandard/Sniffs/Namespaces/UseSpacingSniff.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,10 @@ private function checkLinesAfterLastUse(File $phpcsFile, UseStatement $lastUse):
143143

144144
if (
145145
in_array($tokens[$pointerAfterWhitespaceEnd]['code'], Tokens::$commentTokens, true)
146-
&& $tokens[$useEndPointer]['line'] + 1 === $tokens[$pointerAfterWhitespaceEnd]['line']
146+
&& (
147+
$tokens[$useEndPointer]['line'] === $tokens[$pointerAfterWhitespaceEnd]['line']
148+
|| $tokens[$useEndPointer]['line'] + 1 === $tokens[$pointerAfterWhitespaceEnd]['line']
149+
)
147150
) {
148151
$useEndPointer = array_key_exists('comment_closer', $tokens[$pointerAfterWhitespaceEnd])
149152
? $tokens[$pointerAfterWhitespaceEnd]['comment_closer']
@@ -221,6 +224,7 @@ private function checkLinesBetweenSameTypesOfUse(File $phpcsFile, array $useStat
221224

222225
if (
223226
in_array($tokens[$pointerBeforeUse]['code'], Tokens::$commentTokens, true)
227+
&& TokenHelper::findFirstNonWhitespaceOnLine($phpcsFile, $pointerBeforeUse) === $pointerBeforeUse
224228
&& $tokens[$pointerBeforeUse]['line'] + 1 === $tokens[$useStartPointer]['line']
225229
) {
226230
$useStartPointer = array_key_exists('comment_opener', $tokens[$pointerBeforeUse])
@@ -296,6 +300,7 @@ private function checkLinesBetweenDifferentTypesOfUse(File $phpcsFile, array $us
296300

297301
if (
298302
in_array($tokens[$pointerBeforeUse]['code'], Tokens::$commentTokens, true)
303+
&& TokenHelper::findFirstNonWhitespaceOnLine($phpcsFile, $pointerBeforeUse) === $pointerBeforeUse
299304
&& $tokens[$pointerBeforeUse]['line'] + 1 === $tokens[$useStartPointer]['line']
300305
) {
301306
$useStartPointer = array_key_exists('comment_opener', $tokens[$pointerBeforeUse])

tests/Sniffs/Namespaces/data/useSpacingWithDefaultSettingsNoErrors.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
<?php declare(strict_types = 1);
22

3-
use DateTimeImmutable;
4-
use function phpversion;
5-
use const PHP_VERSION_ID;
3+
use DateTimeImmutable; // WTF comment
4+
use DateTimeInterface;
5+
use DateTime; // WTF comment
6+
use function phpversion; // WTF comment
7+
use function phpinfo; // WTF comment
8+
use const PHP_VERSION_ID; // WTF comment
69

710
?><?php
811

0 commit comments

Comments
 (0)