[clang-sycl-linker] Fix use of uninitialized memory in temp files (llvm#114488)

sarnex · smallp-o-p · commit ae90b735fc04 · 2024-11-03T01:23:07.000-04:00
This fixes the current sanitizer CI [failures](https://lab.llvm.org/buildbot/#/builders/169/builds/4839/steps/13/logs/stdio). I manually confirmed the fix with a MemorySanitizer build. Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
diff --git a/clang/tools/clang-sycl-linker/ClangSYCLLinker.cpp b/clang/tools/clang-sycl-linker/ClangSYCLLinker.cpp
@@ -230,7 +230,7 @@ Expected<StringRef> linkDeviceInputFiles(ArrayRef<std::string> InputFiles,
   CmdArgs.push_back("--suppress-warnings");
   if (Error Err = executeCommands(*LLVMLinkPath, CmdArgs))
     return std::move(Err);
-  return *OutFileOrErr;
+  return Args.MakeArgString(*OutFileOrErr);
 }
 
 // This utility function is used to gather all SYCL device library files that

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ Expected<StringRef> linkDeviceInputFiles(ArrayRef<std::string> InputFiles,`
`230`	`230`	`CmdArgs.push_back("--suppress-warnings");`
`231`	`231`	`if (Error Err = executeCommands(*LLVMLinkPath, CmdArgs))`
`232`	`232`	`return std::move(Err);`
`233`		`- return *OutFileOrErr;`
	`233`	`+ return Args.MakeArgString(*OutFileOrErr);`
`234`	`234`	`}`
`235`	`235`
`236`	`236`	`// This utility function is used to gather all SYCL device library files that`