Merge pull request #99 from simPod/improve-insert

Do not allow to execute insert with empty values

Author: isublimity

src/Client.php

@@ -461,15 +461,15 @@ public function getCountPendingQueue()
     }
 
     /**
-     * Insert Array
-     *
      * @param mixed[][] $values
      * @param string[]  $columns
-     * @return Statement
-     * @throws Exception\TransportException
      */
-    public function insert(string $table, $values, $columns = [])
+    public function insert(string $table, array $values, array $columns = []) : Statement
     {
+        if (empty($values)) {
+            throw QueryException::cannotInsertEmptyValues();
+        }
+
         if (stripos($table, '`') === false && stripos($table, '.') === false) {
             $table = '`' . $table . '`'; //quote table name for dot names
         }

src/Exception/QueryException.php

@@ -8,4 +8,8 @@
 
 class QueryException extends LogicException implements ClickHouseException
 {
+    public static function cannotInsertEmptyValues() : self
+    {
+        return new self('Inserting empty values array is not supported in ClickHouse');
+    }
 }

tests/ClientTest.php

@@ -788,6 +788,14 @@ public function testExceptionInsert()
         ], ['s_key', 's_arr']);
     }
 
+    public function testExceptionInsertNoData() : void
+    {
+        $this->expectException(QueryException::class);
+        $this->expectExceptionMessage('Inserting empty values array is not supported in ClickHouse');
+
+        $this->client->insert('bla_bla', []);
+    }
+
     public function testExceptionSelect()
     {
         $this->expectException(DatabaseException::class);