Export enums as const

Author: srchase

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/EnumGenerator.java

@@ -88,7 +88,7 @@ private void generateUnnamedEnum() {
     // Named enums generate an actual enum type.
     private void generateNamedEnum() {
         writer.writeDocs("@public")
-            .openBlock("export enum $L {", "}", symbol.getName(), () -> {
+            .openBlock("export const $L = {", "}", symbol.getName(), () -> {
                 // Sort the named values to ensure a stable order and sane diffs.
                 // TODO: Should we just sort these in the trait itself?
                 enumTrait.getValues()
@@ -103,6 +103,6 @@ private void writeNamedEnumConstant(EnumDefinition body) {
 
         String name = body.getName().get();
         body.getDocumentation().ifPresent(writer::writeDocs);
-        writer.write("$L = $S,", TypeScriptUtils.sanitizePropertyName(name), body.getValue());
+        writer.write("$L: $S,", TypeScriptUtils.sanitizePropertyName(name), body.getValue());
     }
 }

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/SymbolVisitor.java

@@ -370,7 +370,7 @@ public Symbol memberShape(MemberShape shape) {
     private Symbol createMemberSymbolWithEnumTarget(Symbol targetSymbol) {
         return targetSymbol.toBuilder()
                 .namespace(null, "/")
-                .name(targetSymbol.getName() + " | string")
+                .name("keyof typeof " + targetSymbol.getName() + " | string")
                 .addReference(targetSymbol)
                 .build();
     }

smithy-typescript-codegen/src/test/java/software/amazon/smithy/typescript/codegen/EnumGeneratorTest.java

@@ -33,8 +33,8 @@ public void generatesNamedEnums() {
         Symbol symbol = new SymbolVisitor(model, settings).toSymbol(shape);
         new EnumGenerator(shape, symbol, writer).run();
 
-        assertThat(writer.toString(), containsString("export enum Baz {"));
-        assertThat(writer.toString(), stringContainsInOrder("BAR = \"BAR\",", "FOO = \"FOO\""));
+        assertThat(writer.toString(), containsString("export const Baz = {"));
+        assertThat(writer.toString(), stringContainsInOrder("BAR: \"BAR\",", "FOO: \"FOO\""));
     }
 
     @Test

smithy-typescript-codegen/src/test/java/software/amazon/smithy/typescript/codegen/SymbolProviderTest.java

@@ -218,7 +218,7 @@ public void addsUnknownStringEnumVariant() {
         SymbolProvider provider = new SymbolVisitor(model, settings);
         Symbol memberSymbol = provider.toSymbol(member);
 
-        assertThat(memberSymbol.getName(), equalTo("EnumString | string"));
+        assertThat(memberSymbol.getName(), equalTo("keyof typeof EnumString | string"));
     }
 
     @Test