Skip to content

Commit 1692067

Browse files
committed
fix: use entities instead of he
1 parent 871ffaf commit 1692067

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/HttpProtocolTestGenerator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,7 @@ private String registerBodyComparatorStub(String mediaType) {
461461
writer.addDependency(TypeScriptDependency.XML_PARSER);
462462
writer.addDependency(TypeScriptDependency.HTML_ENTITIES);
463463
writer.addImport("parse", "xmlParse", "fast-xml-parser");
464-
writer.addImport("decode", "heDecode", "he");
464+
writer.addImport("decodeHTML", "decodeHTML", "entities");
465465
additionalStubs.add("protocol-test-xml-stub.ts");
466466
return "compareEquivalentXmlBodies(bodyString, r.body.toString())";
467467
case "application/octet-stream":

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptDependency.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ public enum TypeScriptDependency implements SymbolDependencyContainer {
7878

7979
// Conditionally added when XML parser needs to be used.
8080
XML_PARSER("dependencies", "fast-xml-parser", "3.19.0", false),
81-
HTML_ENTITIES("dependencies", "he", "1.2.0", false),
82-
TYPES_HTML_ENTITIES("devDependencies", "@types/he", "1.1.1", false);
81+
HTML_ENTITIES("dependencies", "entities", "2.2.0", false);
8382

8483
public static final String NORMAL_DEPENDENCY = "dependencies";
8584
public static final String DEV_DEPENDENCY = "devDependencies";

smithy-typescript-codegen/src/main/resources/software/amazon/smithy/typescript/codegen/protocol-test-xml-stub.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const compareEquivalentXmlBodies = (
1212
parseNodeValue: false,
1313
trimValues: false,
1414
tagValueProcessor: (val: any, tagName: any) =>
15-
val.trim() === "" ? "" : heDecode(val),
15+
val.trim() === "" ? "" : decodeHTML(val),
1616
};
1717

1818
const parseXmlBody = (body: string) => {

0 commit comments

Comments
 (0)