Skip to content

Commit 1bb22be

Browse files
committed
Fix for ./gradlew test to be successful
1 parent 3c73a41 commit 1bb22be

File tree

3 files changed

+19
-12
lines changed

3 files changed

+19
-12
lines changed

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructureGenerator.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import software.amazon.smithy.codegen.core.SymbolProvider;
2222
import software.amazon.smithy.codegen.core.SymbolReference;
2323
import software.amazon.smithy.model.Model;
24-
import software.amazon.smithy.model.shapes.MemberShape;
2524
import software.amazon.smithy.model.shapes.StructureShape;
2625
import software.amazon.smithy.model.traits.ErrorTrait;
2726

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructuredMemberWriter.java

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,11 @@ void writeFilterSensitiveLog(TypeScriptWriter writer, String objectParam) {
9898
/**
9999
* Recursively writes filterSensitiveLog for StructureShape.
100100
*/
101-
private void writeStructureFilterSensitiveLog(TypeScriptWriter writer, Shape structureTarget, String structureParam) {
101+
private void writeStructureFilterSensitiveLog(
102+
TypeScriptWriter writer,
103+
Shape structureTarget,
104+
String structureParam
105+
) {
102106
if (structureTarget.getMemberTrait(model, SensitiveTrait.class).isPresent()) {
103107
// member is Sensitive, hide the value.
104108
writer.write("SENSITIVE_STRING");
@@ -111,7 +115,11 @@ private void writeStructureFilterSensitiveLog(TypeScriptWriter writer, Shape str
111115
/**
112116
* Recursively writes filterSensitiveLog for CollectionShape.
113117
*/
114-
private void writeCollectionFilterSensitiveLog(TypeScriptWriter writer, MemberShape collectionMember, String collectionParam) {
118+
private void writeCollectionFilterSensitiveLog(
119+
TypeScriptWriter writer,
120+
MemberShape collectionMember,
121+
String collectionParam
122+
) {
115123
if (collectionMember.getMemberTrait(model, SensitiveTrait.class).isPresent()) {
116124
// member is Sensitive, hide the value.
117125
writer.write("SENSITIVE_STRING");
@@ -162,7 +170,7 @@ private void writeMapFilterSensitiveLog(TypeScriptWriter writer, MemberShape map
162170
mapParam, accParam, keyParam, valueParam, symbolProvider.toSymbol(mapMember), () -> {
163171
writer.write("...$L,", accParam);
164172
Shape memberTarget = model.expectShape(mapMember.getTarget());
165-
writer.openBlock("[$L]: ",",", keyParam, () -> {
173+
writer.openBlock("[$L]: ", ",", keyParam, () -> {
166174
if (memberTarget instanceof StructureShape) {
167175
writeStructureFilterSensitiveLog(writer, memberTarget, valueParam);
168176
} else if (memberTarget instanceof CollectionShape) {
@@ -189,15 +197,15 @@ private void writeMapFilterSensitiveLog(TypeScriptWriter writer, MemberShape map
189197

190198
/**
191199
* Identifies if iteration is required on member.
192-
*
200+
*
193201
* @param member a {@link MemberShape} to check for iteration required.
194202
* @return Returns true if the iteration is required on member.
195203
*/
196204
private boolean isIterationRequired(MemberShape member) {
197205
Shape memberTarget = model.expectShape(member.getTarget());
198206
if (memberTarget instanceof StructureShape) {
199207
return true;
200-
} if (memberTarget instanceof CollectionShape) {
208+
} else if (memberTarget instanceof CollectionShape) {
201209
MemberShape collectionMember = ((CollectionShape) memberTarget).getMember();
202210
return isIterationRequired(collectionMember);
203211
} else if (memberTarget instanceof MapShape) {
@@ -209,7 +217,7 @@ private boolean isIterationRequired(MemberShape member) {
209217

210218
/**
211219
* Identifies if member needs to be overwritten in filterSensitiveLog.
212-
*
220+
*
213221
* @param member a {@link MemberShape} to check if overwrite is required.
214222
* @return Returns true if the overwrite is required on member.
215223
*/
@@ -220,7 +228,8 @@ private boolean isMemberOverwriteRequired(MemberShape member) {
220228
}
221229

222230
/**
223-
*
231+
* Returns sanitized value of the member.
232+
*
224233
* @param member a {@link MemberShape} to be sanitized.
225234
* @return Returns sanitized value of the member
226235
*/

smithy-typescript-codegen/src/test/java/software/amazon/smithy/typescript/codegen/StructureGeneratorTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,9 @@ public void testErrorStructureCodegen(String file, String expectedType) {
6565
assertThat(contents, containsString("as __isa"));
6666
assertThat(contents, containsString("as __SmithyException"));
6767
assertThat(contents, containsString(expectedType));
68-
assertThat(contents, containsString("namespace Err {\n"
69-
+ " export const isa = (o: any): o is Err => "
70-
+ "__isa(o, \"Err\");\n"
71-
+ "}"));
68+
assertThat(contents, containsString("namespace Err {"));
69+
assertThat(contents, containsString(" export const isa = (o: any): o is Err => "
70+
+ "__isa(o, \"Err\");\n"));
7271
}
7372

7473
@Test

0 commit comments

Comments
 (0)