Skip to content

Commit 252e34b

Browse files
committed
Clarify TODO for refactoring generateProtocolTests usage
1 parent 41b0d5e commit 252e34b

File tree

1 file changed

+2
-0
lines changed
  • smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/integration

1 file changed

+2
-0
lines changed

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/integration/ProtocolGenerator.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,8 @@ public void setSymbolProvider(SymbolProvider symbolProvider) {
314314
// where the constructor asserts that both writer/writerDelegator are not set, instead of unsetting the other.
315315
// Or consider specialized GenerationContextWithWriter/GenerationContextWithWriterDelegator to use in
316316
// corresponding ProtocolGenerator methods that need writer v/s writerDelegator.
317+
// OR better refactor to add something like a `areProtocolTestsPresent()` so `generateProtocolTests` is called
318+
// and `writer` created only if needed.
317319
public TypeScriptDelegator getWriterDelegator() {
318320
return writerDelegator;
319321
}

0 commit comments

Comments
 (0)