fix(node-http-handler): Write request body if 100 Continue response times out

Author: Nevon

.changeset/good-buttons-relax.md

@@ -0,0 +1,5 @@
+---
+"@smithy/node-http-handler": patch
+---
+
+fix sending request when 100 Continue response takes more than 1 second

packages/node-http-handler/src/write-request-body.spec.ts

@@ -59,4 +59,25 @@ describe(writeRequestBody.name, () => {
       await promise;
     }
   );
+
+  it("should send the body if the 100 Continue response is not received" + "before the timeout", async () => {
+    const httpRequest = Object.assign(new EventEmitter(), {
+      end: vi.fn(),
+    }) as any;
+    const request = {
+      headers: {
+        expect: "100-continue",
+      },
+      body: Buffer.from("abcd"),
+      method: "GET",
+      hostname: "",
+      protocol: "https:",
+      path: "/",
+    };
+
+    const promise = writeRequestBody(httpRequest, request);
+    expect(httpRequest.end).not.toHaveBeenCalled();
+    await promise;
+    expect(httpRequest.end).toHaveBeenCalled();
+  });
 });

packages/node-http-handler/src/write-request-body.ts

@@ -28,7 +28,7 @@ export async function writeRequestBody(
   if (expect === "100-continue") {
     sendBody = await Promise.race<boolean>([
       new Promise((resolve) => {
-        timeoutId = Number(timing.setTimeout(resolve, Math.max(MIN_WAIT_TIME, maxContinueTimeoutMs)));
+        timeoutId = Number(timing.setTimeout(() => resolve(true), Math.max(MIN_WAIT_TIME, maxContinueTimeoutMs)));
       }),
       new Promise((resolve) => {
         httpRequest.on("continue", () => {