Do not create new ApplicationProtocol every time

Author: gosar

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java

@@ -86,7 +86,8 @@ public abstract class HttpBindingProtocolGenerator implements ProtocolGenerator
     private static final Logger LOGGER = Logger.getLogger(HttpBindingProtocolGenerator.class.getName());
     private static final Set<Character> REGEX_CHARS = SetUtils.of('.', '*', '+', '?', '^', '$', '{', '}', '(',
             ')', '|', '[', ']', '\\');
-
+    private static final ApplicationProtocol APPLICATION_PROTOCOL
+            = ApplicationProtocol.createDefaultHttpApplicationProtocol();
     private final Set<Shape> serializingDocumentShapes = new TreeSet<>();
     private final Set<Shape> deserializingDocumentShapes = new TreeSet<>();
     private final Set<StructureShape> serializingErrorShapes = new TreeSet<>();
@@ -108,8 +109,8 @@ public HttpBindingProtocolGenerator(boolean isErrorCodeInBody) {
     }
 
     @Override
-    public ApplicationProtocol getApplicationProtocol() {
-        return ApplicationProtocol.createDefaultHttpApplicationProtocol();
+    public final ApplicationProtocol getApplicationProtocol() {
+        return APPLICATION_PROTOCOL;
     }
 
     /**

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/integration/HttpRpcProtocolGenerator.java

@@ -39,6 +39,8 @@
 public abstract class HttpRpcProtocolGenerator implements ProtocolGenerator {
 
     public static final Logger LOGGER = Logger.getLogger(HttpRpcProtocolGenerator.class.getName());
+    private static final ApplicationProtocol APPLICATION_PROTOCOL
+            = ApplicationProtocol.createDefaultHttpApplicationProtocol();
 
     private final Set<Shape> serializingDocumentShapes = new TreeSet<>();
     private final Set<Shape> deserializingDocumentShapes = new TreeSet<>();
@@ -56,8 +58,8 @@ public HttpRpcProtocolGenerator(boolean isErrorCodeInBody) {
     }
 
     @Override
-    public ApplicationProtocol getApplicationProtocol() {
-        return ApplicationProtocol.createDefaultHttpApplicationProtocol();
+    public final ApplicationProtocol getApplicationProtocol() {
+        return APPLICATION_PROTOCOL;
     }
 
     /**

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/integration/ProtocolGenerator.java

@@ -76,9 +76,9 @@ default String getName() {
     }
 
     /**
-     * Creates an application protocol for the generator.
+     * Gets the application protocol for the generator.
      *
-     * @return Returns the created application protocol.
+     * @return Returns the application protocol.
      */
     ApplicationProtocol getApplicationProtocol();