Skip to content

Commit 54311ee

Browse files
AllanZhengYPsrchase
authored andcommitted
feat: use flag to replace httprequest instanceof
1 parent 524b160 commit 54311ee

File tree

2 files changed

+19
-16
lines changed

2 files changed

+19
-16
lines changed

packages/middleware-content-length/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
},
1515
"license": "Apache-2.0",
1616
"dependencies": {
17-
"@aws-sdk/types": "^0.1.0-preview.7",
17+
"@aws-sdk/types": "^0.1.0-preview.5",
18+
"@aws-sdk/protocol-http": "^0.1.0-preview.1",
1819
"tslib": "^1.8.0"
1920
},
2021
"devDependencies": {

packages/middleware-content-length/src/index.ts

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import {
44
BuildMiddleware,
55
BodyLengthCalculator,
66
MetadataBearer,
7-
BuildHandlerOutput,
8-
HttpRequest
7+
BuildHandlerOutput
98
} from "@aws-sdk/types";
9+
import { HttpRequest } from "@aws-sdk/protocol-http";
1010

1111
export function contentLengthMiddleware(
1212
bodyLengthCalculator: BodyLengthCalculator
@@ -18,19 +18,21 @@ export function contentLengthMiddleware(
1818
): Promise<BuildHandlerOutput<Output>> => {
1919
let request = { ...args.request };
2020
//TODO: cast request with instanceof
21-
const { body, headers } = <HttpRequest>request;
22-
if (
23-
body &&
24-
Object.keys(headers)
25-
.map(str => str.toLowerCase())
26-
.indexOf("content-length") === -1
27-
) {
28-
const length = bodyLengthCalculator(body);
29-
if (length !== undefined) {
30-
(<HttpRequest>request).headers = {
31-
...(<HttpRequest>request).headers,
32-
"Content-Length": String(length)
33-
};
21+
if (HttpRequest.isHttpRequest(request)) {
22+
const { body, headers } = request;
23+
if (
24+
body &&
25+
Object.keys(headers)
26+
.map(str => str.toLowerCase())
27+
.indexOf("content-length") === -1
28+
) {
29+
const length = bodyLengthCalculator(body);
30+
if (length !== undefined) {
31+
request.headers = {
32+
...request.headers,
33+
"Content-Length": String(length)
34+
};
35+
}
3436
}
3537
}
3638

0 commit comments

Comments
 (0)