fix: update updated types (#474)

* Use HttpRequest interface instread of class when implementation is not necessary
* Make request serializer async just like response deserializer. This makes the serde symmetric

Author: AllanZhengYP

packages/middleware-content-length/src/index.ts

@@ -10,6 +10,8 @@ import {
 } from "@aws-sdk/types";
 import { HttpRequest } from "@aws-sdk/protocol-http";
 
+const CONTENT_LENGTH_HEADER = "content-length";
+
 export function contentLengthMiddleware(
   bodyLengthChecker: BodyLengthCalculator
 ): BuildMiddleware<any, any> {
@@ -18,21 +20,20 @@ export function contentLengthMiddleware(
   ): BuildHandler<any, Output> => async (
     args: BuildHandlerArguments<any>
   ): Promise<BuildHandlerOutput<Output>> => {
-    let request = { ...args.request };
-    //TODO: cast request with instanceof
+    let request = args.request;
     if (HttpRequest.isInstance(request)) {
       const { body, headers } = request;
       if (
         body &&
         Object.keys(headers)
           .map(str => str.toLowerCase())
-          .indexOf("content-length") === -1
+          .indexOf(CONTENT_LENGTH_HEADER) === -1
       ) {
         const length = bodyLengthChecker(body);
         if (length !== undefined) {
           request.headers = {
             ...request.headers,
-            "Content-Length": String(length)
+            CONTENT_LENGTH_HEADER: String(length)
           };
         }
       }

packages/middleware-serde/src/serializerMiddleware.ts

@@ -28,7 +28,7 @@ export function serializerMiddleware<
       ...options,
       endpoint: await options.endpoint()
     };
-    const request = serializer(
+    const request = await serializer(
       args.input,
       options.protocol,
       endpointResolvedOptions

packages/middleware-serde/tsconfig.json

@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es5",
+    "target": "es2016",
     "module": "commonjs",
     "declaration": true,
     "strict": true,

packages/node-http-handler/src/server.mock.ts

@@ -17,7 +17,7 @@ import { HttpResponse } from "@aws-sdk/types";
 
 const fixturesDir = join(__dirname, "..", "fixtures");
 
-export function createResponseFunction(httpResp: HttpResponse<Readable>) {
+export function createResponseFunction(httpResp: HttpResponse) {
   return function(request: IncomingMessage, response: ServerResponse) {
     response.statusCode = httpResp.statusCode;
     for (let name of Object.keys(httpResp.headers)) {
@@ -32,9 +32,7 @@ export function createResponseFunction(httpResp: HttpResponse<Readable>) {
   };
 }
 
-export function createContinueResponseFunction(
-  httpResp: HttpResponse<Readable>
-) {
+export function createContinueResponseFunction(httpResp: HttpResponse) {
   return function(request: IncomingMessage, response: ServerResponse) {
     response.writeContinue();
     setTimeout(() => {

packages/node-http-handler/src/write-request-body.ts

@@ -5,7 +5,7 @@ import { HttpRequest } from "@aws-sdk/types";
 
 export function writeRequestBody(
   httpRequest: ClientRequest | ClientHttp2Stream,
-  request: HttpRequest<Readable>
+  request: HttpRequest
 ) {
   const expect = request.headers["Expect"] || request.headers["expect"];
   if (expect === "100-continue") {

packages/node-http-handler/tsconfig.json

@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es5",
+    "target": "es2017",
     "module": "commonjs",
     "declaration": true,
     "strict": true,

packages/signature-v4/package.json

@@ -26,8 +26,8 @@
   },
   "devDependencies": {
     "@aws-crypto/sha256-js": "^0.1.0-preview.1",
-    "@aws-sdk/http-serialization": "^0.1.0-preview.7",
     "@aws-sdk/util-buffer-from": "^0.1.0-preview.3",
+    "@aws-sdk/protocol-http": "^0.1.0-preview.1",
     "@types/jest": "^24.0.12",
     "jest": "^24.7.1",
     "typescript": "~3.4.0"