Remove some unnecessary TODOs and unnecessary code

The generator does not produce any .tsx files.

Author: gosar

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/DirectedTypeScriptCodegen.java

@@ -376,7 +376,6 @@ public void customizeBeforeIntegrations(
             directive.fileManifest().writeFile(from, getClass(), to);
         });
 
-        // TODO: do all of these parts below are before/after?
         SymbolVisitor.writeModelIndex(directive.connectedShapes().values(), directive.symbolProvider(),
                 directive.fileManifest());
 

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/ImportDeclarations.java

@@ -32,7 +32,6 @@
 @SmithyInternalApi
 final class ImportDeclarations implements ImportContainer {
 
-    // TODO: remove this
     private final String moduleNameString;
     private final Path relativize;
     private final Map<String, Pair<String, Ignore>> defaultImports = new TreeMap<>();
@@ -82,7 +81,6 @@ ImportDeclarations addImport(String name, String alias, String module) {
 
     @Override
     public void importSymbol(Symbol symbol, String alias) {
-        // TODO: is this if needed?
         if (!symbol.getNamespace().isEmpty() && !symbol.getNamespace().equals(moduleNameString)) {
             addImport(symbol.getName(), alias, symbol.getNamespace());
         }

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptWriter.java

@@ -49,7 +49,6 @@ public final class TypeScriptWriter extends SymbolWriter<TypeScriptWriter, Impor
 
     private final boolean withAttribution;
 
-    // TODO: see if this can be removed
     public TypeScriptWriter(String moduleName) {
         this(moduleName, true);
     }
@@ -69,10 +68,9 @@ public static final class TypeScriptWriterFactory implements SymbolWriter.Factor
 
         @Override
         public TypeScriptWriter apply(String filename, String namespace) {
-            boolean attribution = filename.endsWith(".ts") || filename.endsWith(".tsx");
-            // TODO: Attribution accounts for tsx too, but moduleName doesn't.
+            boolean withAttribution = filename.endsWith(".ts");
             String moduleName = filename.endsWith(".ts") ? filename.substring(0, filename.length() - 3) : filename;
-            return new TypeScriptWriter(moduleName, attribution);
+            return new TypeScriptWriter(moduleName, withAttribution);
         }
     }
 
@@ -97,7 +95,6 @@ public TypeScriptWriter addIgnoredDefaultImport(String name, String from, String
      * @param from Module to import the type from.
      * @return Returns the writer.
      */
-    // TODO: see what references of this method call can be changed to use Symbol instead of String name
     public TypeScriptWriter addImport(String name, String as, String from) {
         getImportContainer().addImport(name, as, from);
         return this;

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/integration/TypeScriptIntegration.java

@@ -41,20 +41,6 @@
 public interface TypeScriptIntegration
         extends SmithyIntegration<TypeScriptSettings, TypeScriptWriter, TypeScriptCodegenContext> {
 
-    /**
-     * Preprocess the model before code generation.
-     *
-     * <p>This can be used to remove unsupported features, remove traits
-     * from shapes (e.g., make members optional), etc.
-     *
-     * @param model Model being generated.
-     * @param settings Setting used to generate.
-     * @return Returns the updated model.
-     */
-    default Model preprocessModel(Model model, TypeScriptSettings settings) {
-        return model;
-    }
-
     /**
      * Writes additional files.
      *