Skip to content

Commit 86bb0d7

Browse files
committed
Fix spotbugs failures
1 parent efa5268 commit 86bb0d7

File tree

2 files changed

+24
-26
lines changed

2 files changed

+24
-26
lines changed

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CodegenVisitor.java

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import java.util.Comparator;
2222
import java.util.HashMap;
2323
import java.util.List;
24-
import java.util.Locale;
2524
import java.util.Map;
2625
import java.util.Objects;
2726
import java.util.ServiceLoader;
@@ -220,18 +219,18 @@ void execute() {
220219

221220
// Generate protocol tests IFF found in the model.
222221
if (protocolGenerator != null) {
223-
ShapeId protocol = protocolGenerator.getProtocol();
224-
ProtocolGenerator.GenerationContext context = new ProtocolGenerator.GenerationContext();
225-
context.setProtocolName(protocolGenerator.getName());
226-
context.setIntegrations(integrations);
227-
context.setModel(model);
228-
context.setService(service);
229-
context.setSettings(settings);
230-
context.setSymbolProvider(symbolProvider);
231-
String baseName = protocol.getName().toLowerCase(Locale.US)
232-
.replace("-", "_")
233-
.replace(".", "_");
234-
String protocolTestFileName = String.format("test/functional/%s.spec.ts", baseName);
222+
// ShapeId protocol = protocolGenerator.getProtocol();
223+
// ProtocolGenerator.GenerationContext context = new ProtocolGenerator.GenerationContext();
224+
// context.setProtocolName(protocolGenerator.getName());
225+
// context.setIntegrations(integrations);
226+
// context.setModel(model);
227+
// context.setService(service);
228+
// context.setSettings(settings);
229+
// context.setSymbolProvider(symbolProvider);
230+
// String baseName = protocol.getName().toLowerCase(Locale.US)
231+
// .replace("-", "_")
232+
// .replace(".", "_");
233+
// String protocolTestFileName = String.format("test/functional/%s.spec.ts", baseName);
235234
// context.setDeferredWriter(() -> writers.checkoutFileWriter(protocolTestFileName));
236235
// protocolGenerator.generateProtocolTests(context);
237236
}

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/DirectedTypeScriptCodegen.java

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import java.util.Collection;
2121
import java.util.HashMap;
2222
import java.util.List;
23-
import java.util.Locale;
2423
import java.util.Map;
2524
import java.util.Set;
2625
import java.util.logging.Logger;
@@ -431,18 +430,18 @@ public void customizeBeforeIntegrations(
431430
// Generate protocol tests IFF found in the model.
432431
ProtocolGenerator protocolGenerator = directive.context().protocolGenerator();
433432
if (protocolGenerator != null) {
434-
ShapeId protocol = protocolGenerator.getProtocol();
435-
ProtocolGenerator.GenerationContext context = new ProtocolGenerator.GenerationContext();
436-
context.setProtocolName(protocolGenerator.getName());
437-
context.setIntegrations(directive.context().integrations());
438-
context.setModel(directive.model());
439-
context.setService(directive.service());
440-
context.setSettings(directive.settings());
441-
context.setSymbolProvider(directive.symbolProvider());
442-
String baseName = protocol.getName().toLowerCase(Locale.US)
443-
.replace("-", "_")
444-
.replace(".", "_");
445-
String protocolTestFileName = String.format("test/functional/%s.spec.ts", baseName);
433+
// ShapeId protocol = protocolGenerator.getProtocol();
434+
// ProtocolGenerator.GenerationContext context = new ProtocolGenerator.GenerationContext();
435+
// context.setProtocolName(protocolGenerator.getName());
436+
// context.setIntegrations(directive.context().integrations());
437+
// context.setModel(directive.model());
438+
// context.setService(directive.service());
439+
// context.setSettings(directive.settings());
440+
// context.setSymbolProvider(directive.symbolProvider());
441+
// String baseName = protocol.getName().toLowerCase(Locale.US)
442+
// .replace("-", "_")
443+
// .replace(".", "_");
444+
// String protocolTestFileName = String.format("test/functional/%s.spec.ts", baseName);
446445

447446
// TODO: what to do here?
448447
// context.setDeferredWriter(() -> directive.context().writerDelegator().checkoutFileWriter

0 commit comments

Comments
 (0)