Skip to content

Commit 87f0395

Browse files
committed
feat: allow undefined when property optional for exactOptionalPropertyTypes
1 parent 0d9cee8 commit 87f0395

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructuredMemberWriter.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,9 @@ void writeMembers(TypeScriptWriter writer, Shape shape) {
106106
String optionalSuffix = shape.isUnionShape() || !isRequiredMember(member) ? "?" : "";
107107
String typeSuffix = requiredMemberMode == RequiredMemberMode.NULLABLE
108108
&& isRequiredMember(member) ? " | undefined" : "";
109+
if (optionalSuffix.equals("?")) {
110+
typeSuffix = " | undefined"; // support exactOptionalPropertyTypes.
111+
}
109112
writer.write("${L}${L}${L}: ${T}${L};", memberPrefix, memberName, optionalSuffix,
110113
symbolProvider.toSymbol(member), typeSuffix);
111114

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ public enum RequiredMemberMode {
558558
NULLABLE("nullable"),
559559

560560
/**
561-
* This will dissallow members marked as {@link RequiredTrait} to be {@code undefined}.
561+
* This will disallow members marked as {@link RequiredTrait} to be {@code undefined}.
562562
* Use this mode with CAUTION because it comes with certain risks. When a server drops
563563
* {@link RequiredTrait} from an output shape (and it is replaced with {@link DefaultTrait}
564564
* as defined by the spec), if the server does not always serialize a value,

0 commit comments

Comments
 (0)