Skip to content

Commit 894a514

Browse files
committed
Clarify why createDedicatedInputsAndOutputs is not used
1 parent ac49787 commit 894a514

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptCodegenPlugin.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,9 @@ public void execute(PluginContext context) {
5656
// Configure the director to perform some common model transforms.
5757
runner.performDefaultCodegenTransforms();
5858

59-
// TODO: How is smithy-typescript currently dealing with no input/output?
60-
// runner.createDedicatedInputsAndOutputs();
59+
// TODO: Not using below because it would break existing AWS SDKs. Maybe it should be configurable
60+
// so generic SDKs call this by default, but AWS SDKs can opt-out of it via a setting.
61+
// runner.createDedicatedInputsAndOutputs();
6162

6263
// Run it!
6364
runner.run();

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptServerCodegenPlugin.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,9 @@ public void execute(PluginContext context) {
5656
// Configure the director to perform some common model transforms.
5757
runner.performDefaultCodegenTransforms();
5858

59-
// TODO: How is smithy-typescript currently dealing with no input/output?
60-
// runner.createDedicatedInputsAndOutputs();
59+
// TODO: Not using below because it would break existing AWS SDKs. Maybe it should be configurable
60+
// so generic SDKs call this by default, but AWS SDKs can opt-out of it via a setting.
61+
// runner.createDedicatedInputsAndOutputs();
6162

6263
// Run it!
6364
runner.run();

0 commit comments

Comments
 (0)