Skip to content

Commit a1274de

Browse files
committed
keep Message in error interface for backwards compatibility
1 parent 080d9ad commit a1274de

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructureGenerator.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,10 +195,10 @@ private void renderErrorStructure() {
195195
writer.write("$$fault: $S;", errorTrait.getValue());
196196
HttpProtocolGeneratorUtils.writeRetryableTrait(writer, shape, ";");
197197
Collection<MemberShape> allMembers = shape.getAllMembers().values().stream().filter((memberShape) -> {
198-
// Error message may exists in "Message" or "message" shape regardless of the model.
199-
// So these members are ignored and left to deserializers to parse them and inject to error object.
198+
// since any error interface must extend from JavaScript Error interface, message member is already required
199+
// in the JavaScript Error interface
200200
String memberName = memberShape.getMemberName();
201-
return !memberName.toLowerCase().equals("message");
201+
return !memberName.equals("message");
202202
}).collect(Collectors.toList());
203203
StructuredMemberWriter structuredMemberWriter = new StructuredMemberWriter(model, symbolProvider, allMembers);
204204
structuredMemberWriter.writeMembers(writer, shape);

0 commit comments

Comments
 (0)