Skip to content

Commit a75f171

Browse files
committed
Use destructuring in writeMapFilterSensitiveLog
1 parent e7ff2fb commit a75f171

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructuredMemberWriter.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -105,23 +105,24 @@ void writeCollectionFilterSensitiveLog(TypeScriptWriter writer, MemberShape coll
105105
*/
106106
void writeMapFilterSensitiveLog(TypeScriptWriter writer, MemberShape mapMember) {
107107
// Reducer is common to all shapes.
108-
writer.openBlock("(acc: any, [key, value]: [string, $T]) => {", "}, {}",
108+
writer.openBlock("(acc: any, [key, value]: [string, $T]) => ({", "}), {}",
109109
symbolProvider.toSymbol(mapMember),
110110
() -> {
111+
writer.write("...acc,");
111112
Shape memberShape = model.expectShape(mapMember.getTarget());
112113
if (memberShape instanceof StructureShape) {
113114
// Call filterSensitiveLog on Structure.
114-
writer.write("acc[key] = $T.filterSensitiveLog(value);",
115+
writer.write("[key]: $T.filterSensitiveLog(value),",
115116
symbolProvider.toSymbol(mapMember));
116117
} else if (memberShape instanceof CollectionShape) {
117-
writer.openBlock("acc[key] = value.map(", ")",
118+
writer.openBlock("[key]: value.map(", "),",
118119
() -> {
119120
MemberShape collectionMember = ((CollectionShape) memberShape).getMember();
120121
writeCollectionFilterSensitiveLog(writer, collectionMember);
121122
}
122123
);
123124
} else if (memberShape instanceof MapShape) {
124-
writer.openBlock("acc[key] = Object.entries(value).reduce(", ")",
125+
writer.openBlock("[key]: Object.entries(value).reduce(", "),",
125126
() -> {
126127
MemberShape nestedMapMember = ((MapShape) memberShape).getValue();
127128
writeMapFilterSensitiveLog(writer, nestedMapMember);
@@ -130,9 +131,8 @@ void writeMapFilterSensitiveLog(TypeScriptWriter writer, MemberShape mapMember)
130131
} else {
131132
// This path will never reach because of recursive isIterationRequired.
132133
// Adding it to not break the code, if it does reach in future.
133-
writer.write("acc[key] = value;");
134+
writer.write("[key]: value,");
134135
}
135-
writer.write("return acc;");
136136
}
137137
);
138138
}

0 commit comments

Comments
 (0)