Update float/int parsing and expectations (#397)

This updates number parsing in http bindings to be more strict. It
also updates the expectation methods used for numbers to be more
specific.

Author: JordonPhillips

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/integration/DocumentMemberDeserVisitor.java

@@ -130,42 +130,42 @@ public String booleanShape(BooleanShape shape) {
 
     @Override
     public String byteShape(ByteShape shape) {
-        return expectNumber();
+        return expectInteger();
     }
 
     @Override
     public String shortShape(ShortShape shape) {
-        return expectNumber();
+        return expectInteger();
     }
 
     @Override
     public String integerShape(IntegerShape shape) {
-        return expectNumber();
+        return expectInteger();
     }
 
     @Override
     public String longShape(LongShape shape) {
-        return expectNumber();
+        return expectInteger();
     }
 
     @Override
     public String floatShape(FloatShape shape) {
-        return handleFloat();
+        return limitedParseFloat();
     }
 
     @Override
     public String doubleShape(DoubleShape shape) {
-        return handleFloat();
+        return limitedParseFloat();
     }
 
-    private String expectNumber() {
-        context.getWriter().addImport("expectNumber", "__expectNumber", "@aws-sdk/smithy-client");
-        return "__expectNumber(" + dataSource + ")";
+    private String expectInteger() {
+        context.getWriter().addImport("expectInt", "__expectInt", "@aws-sdk/smithy-client");
+        return "__expectInt(" + dataSource + ")";
     }
 
-    private String handleFloat() {
-        context.getWriter().addImport("handleFloat", "__handleFloat", "@aws-sdk/smithy-client");
-        return "__handleFloat(" + dataSource + ")";
+    private String limitedParseFloat() {
+        context.getWriter().addImport("limitedParseFloat", "__limitedParseFloat", "@aws-sdk/smithy-client");
+        return "__limitedParseFloat(" + dataSource + ")";
     }
 
     @Override

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java

@@ -1135,7 +1135,7 @@ private String getCollectionInputParam(
             dataSource = "Array.from(" + dataSource + ".values())";
         }
         String collectionTargetValue = getInputValue(context, bindingType, "_entry", targetMember, collectionTarget);
-        String iteratedParam = "(" + dataSource + " || []).map(_entry => " + collectionTargetValue + ")";
+        String iteratedParam = "(" + dataSource + " || []).map(_entry => " + collectionTargetValue + " as any)";
         switch (bindingType) {
             case HEADER:
                 return iteratedParam + ".join(', ')";
@@ -2565,7 +2565,7 @@ private String getOutputValue(
             Shape target
     ) {
         if (target instanceof NumberShape) {
-            return getNumberOutputParam(bindingType, dataSource, target);
+            return getNumberOutputParam(context, bindingType, dataSource, target);
         } else if (target instanceof BooleanShape) {
             return getBooleanOutputParam(context, bindingType, dataSource);
         } else if (target instanceof StringShape) {
@@ -2691,15 +2691,15 @@ private String getCollectionOutputParam(
         switch (bindingType) {
             case QUERY_PARAMS:
             case QUERY:
-                return String.format("%1$s.map(_entry => %2$s)",
+                return String.format("%1$s.map(_entry => %2$s as any)",
                         dataSource, collectionTargetValue);
             case LABEL:
                 dataSource = "(" + dataSource + " || \"\")";
                 // Split these values on slashes.
                 outputParam = "" + dataSource + ".split('/')";
 
                 // Iterate over each entry and do deser work.
-                outputParam += ".map(_entry => " + collectionTargetValue + ")";
+                outputParam += ".map(_entry => " + collectionTargetValue + " as any)";
 
                 return outputParam;
             case HEADER:
@@ -2722,7 +2722,7 @@ private String getCollectionOutputParam(
                 }
 
                 // Iterate over each entry and do deser work.
-                outputParam += ".map(_entry => " + collectionTargetValue + ")";
+                outputParam += ".map(_entry => " + collectionTargetValue + " as any)";
 
                 return outputParam;
             default:
@@ -2770,15 +2770,22 @@ private String getNamedMembersOutputParam(
      * @param target The shape of the value being provided.
      * @return Returns a value or expression of the output number.
      */
-    private String getNumberOutputParam(Location bindingType, String dataSource, Shape target) {
+    private String getNumberOutputParam(
+            GenerationContext context,
+            Location bindingType,
+            String dataSource,
+            Shape target
+    ) {
         switch (bindingType) {
             case QUERY:
             case LABEL:
             case HEADER:
                 if (target instanceof FloatShape || target instanceof DoubleShape) {
-                    return "parseFloat(" + dataSource + ")";
+                    context.getWriter().addImport("strictParseFloat", "__strictParseFloat", "@aws-sdk/smithy-client");
+                    return "__strictParseFloat(" + dataSource + ")";
                 }
-                return "parseInt(" + dataSource + ", 10)";
+                context.getWriter().addImport("strictParseInt", "__strictParseInt", "@aws-sdk/smithy-client");
+                return "__strictParseInt(" + dataSource + ")";
             default:
                 throw new CodegenException("Unexpected number binding location `" + bindingType + "`");
         }

smithy-typescript-codegen/src/test/java/software/amazon/smithy/typescript/codegen/integration/DocumentMemberDeserVisitorTest.java

@@ -69,12 +69,12 @@ public static Collection<Object[]> validMemberTargetTypes() {
 
         return ListUtils.of(new Object[][]{
                 {BooleanShape.builder().id(id).build(), "__expectBoolean(" + DATA_SOURCE + ")"},
-                {ByteShape.builder().id(id).build(), "__expectNumber(" + DATA_SOURCE + ")"},
-                {DoubleShape.builder().id(id).build(), "__handleFloat(" + DATA_SOURCE + ")"},
-                {FloatShape.builder().id(id).build(), "__handleFloat(" + DATA_SOURCE + ")"},
-                {IntegerShape.builder().id(id).build(), "__expectNumber(" + DATA_SOURCE + ")"},
-                {LongShape.builder().id(id).build(), "__expectNumber(" + DATA_SOURCE + ")"},
-                {ShortShape.builder().id(id).build(), "__expectNumber(" + DATA_SOURCE + ")"},
+                {ByteShape.builder().id(id).build(), "__expectInt(" + DATA_SOURCE + ")"},
+                {DoubleShape.builder().id(id).build(), "__limitedParseFloat(" + DATA_SOURCE + ")"},
+                {FloatShape.builder().id(id).build(), "__limitedParseFloat(" + DATA_SOURCE + ")"},
+                {IntegerShape.builder().id(id).build(), "__expectInt(" + DATA_SOURCE + ")"},
+                {LongShape.builder().id(id).build(), "__expectInt(" + DATA_SOURCE + ")"},
+                {ShortShape.builder().id(id).build(), "__expectInt(" + DATA_SOURCE + ")"},
                 {StringShape.builder().id(id).build(), "__expectString(" + DATA_SOURCE + ")"},
                 {
                     StringShape.builder().id(id).addTrait(new MediaTypeTrait("foo+json")).build(),