fix: call he from protocol-test-xml-stub

Author: trivikr

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/HttpProtocolTestGenerator.java

@@ -459,7 +459,9 @@ private String registerBodyComparatorStub(String mediaType) {
                 return "compareEquivalentJsonBodies(bodyString, r.body.toString())";
             case "application/xml":
                 writer.addDependency(TypeScriptDependency.XML_PARSER);
+                writer.addDependency(TypeScriptDependency.HTML_ENTITIES);
                 writer.addImport("parse", "xmlParse", "fast-xml-parser");
+                writer.addImport("decode", "heDecode", "he");
                 additionalStubs.add("protocol-test-xml-stub.ts");
                 return "compareEquivalentXmlBodies(bodyString, r.body.toString())";
             case "application/octet-stream":

smithy-typescript-codegen/src/main/resources/software/amazon/smithy/typescript/codegen/protocol-test-xml-stub.ts

@@ -2,22 +2,17 @@
  * Returns a map of key names that were un-equal to value objects showing the
  * discrepancies between the components.
  */
-const compareEquivalentXmlBodies = (expectedBody: string, generatedBody: string): Object => {
-  const decodeEscapedXml = (str: string) => {
-    return str
-      .replace(/&/g, "&")
-      .replace(/'/g, "'")
-      .replace(/"/g, '"')
-      .replace(/>/g, ">")
-      .replace(/&lt;/g, "<");
-  };
-
+const compareEquivalentXmlBodies = (
+  expectedBody: string,
+  generatedBody: string
+): Object => {
   const parseConfig = {
-    attributeNamePrefix: '',
+    attributeNamePrefix: "",
     ignoreAttributes: false,
     parseNodeValue: false,
     trimValues: false,
-    tagValueProcessor: (val: any, tagName: any) => val.trim() === "" ? "" : decodeEscapedXml(val)
+    tagValueProcessor: (val: any, tagName: any) =>
+      val.trim() === "" ? "" : heDecode(val),
   };
 
   const parseXmlBody = (body: string) => {
@@ -36,4 +31,4 @@ const compareEquivalentXmlBodies = (expectedBody: string, generatedBody: string)
   const generatedParts = parseXmlBody(generatedBody);
 
   return compareParts(expectedParts, generatedParts);
-}
+};