You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Align protocol test query param logic with APIG behavior
We use APIGateway multi-value query parameters which will always use an array
value for query parameters, even if they're specified only once, and even if
that single specification does not have a value. Our translation logic from
APIG preserves this structure, and since all query parameters can have multiple
values, this isn't necessarily wrong. Our handling of query parameters is
actually broken in main, but protocol tests don't uncover this due to the logic
that generates non-array values for single query parameters. Streamlining our
generated requests in protocol tests uncovers this bug, and aligns more closely
with how our code runs in the wild.
Copy file name to clipboardExpand all lines: smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/HttpProtocolTestGenerator.java
0 commit comments