fix types and formatting

Author: kuhe

packages/middleware-retry/src/retryMiddleware.ts

@@ -56,14 +56,14 @@ export const retryMiddleware = (options: RetryResolvedConfig & Partial<Previousl
         if (isRequest) {
           request.headers[REQUEST_HEADER] = `attempt=${attempts + 1}; max=${maxAttempts}`;
         }
-        initialSystemClockOffset = options.systemClockOffset | 0;
+        initialSystemClockOffset = options.systemClockOffset ?? 0 | 0;
         const { response, output } = await next(args);
         retryStrategy.recordSuccess(retryToken);
         output.$metadata.attempts = attempts + 1;
         output.$metadata.totalRetryDelay = totalRetryDelay;
         return { response, output };
       } catch (e: unknown) {
-        const latestSystemClockOffset = options.systemClockOffset | 0;
+        const latestSystemClockOffset = options.systemClockOffset ?? 0 | 0;
         const clockSkewCorrected = initialSystemClockOffset !== latestSystemClockOffset;
 
         const sdkError = e as SkdErrorWithClockSkewMetadata;

packages/service-error-classification/src/index.ts

@@ -23,13 +23,13 @@ export const isThrottlingError = (error: SdkError) =>
  * cause where the NodeHttpHandler does not decorate the Error with
  * the name "TimeoutError" to be checked by the TRANSIENT_ERROR_CODES condition.
  */
-export const isTransientError = (error: SkdErrorWithClockSkewMetadata) =>
-  error.$metadata?.clockSkewCorrected ||
+export const isTransientError = (error: SdkError | SkdErrorWithClockSkewMetadata) =>
+  (error as SkdErrorWithClockSkewMetadata).$metadata?.clockSkewCorrected ||
   TRANSIENT_ERROR_CODES.includes(error.name) ||
   NODEJS_TIMEOUT_ERROR_CODES.includes((error as { code?: string })?.code || "") ||
   TRANSIENT_ERROR_STATUS_CODES.includes(error.$metadata?.httpStatusCode || 0);
 
-export const isServerError = (error: SkdErrorWithClockSkewMetadata) => {
+export const isServerError = (error: SdkError | SkdErrorWithClockSkewMetadata) => {
   if (error.$metadata?.httpStatusCode !== undefined) {
     const statusCode = error.$metadata.httpStatusCode;
     if (500 <= statusCode && statusCode <= 599 && !isTransientError(error)) {