fix: update updated types (#474)

* Use HttpRequest interface instread of class when implementation is not necessary
* Make request serializer async just like response deserializer. This makes the serde symmetric

Author: AllanZhengYP

packages/protocol-http/package.json

@@ -16,7 +16,7 @@
   "license": "Apache-2.0",
   "dependencies": {
     "tslib": "^1.8.0",
-    "@aws-sdk/types": "^0.1.0-preview.4",
+    "@aws-sdk/types": "^0.1.0-preview.5",
     "@aws-sdk/util-uri-escape": "^0.1.0-preview.3"
   },
   "devDependencies": {

packages/protocol-http/src/http.ts

@@ -1,15 +1,18 @@
 import { escapeUri } from "@aws-sdk/util-uri-escape";
 import {
   HttpMessage,
-  HttpEndpoint,
+  Endpoint,
   QueryParameterBag,
-  HeaderBag
-} from "./http";
+  HeaderBag,
+  HttpRequest as IHttpRequest
+} from "@aws-sdk/types";
 
 type HttpRequestOptions = Partial<HttpMessage> &
-  Partial<HttpEndpoint> & { method?: string };
+  Partial<Endpoint> & { method?: string };
 
-export class HttpRequest implements HttpMessage, HttpEndpoint {
+export interface HttpRequest extends IHttpRequest {}
+
+export class HttpRequest implements HttpMessage, Endpoint {
   public method: string;
   public protocol: string;
   public hostname: string;
@@ -18,7 +21,6 @@ export class HttpRequest implements HttpMessage, HttpEndpoint {
   public query: QueryParameterBag;
   public headers: HeaderBag;
   public body?: any;
-  private readonly isHttpRequest = true;
 
   constructor(options: HttpRequestOptions) {
     this.method = options.method || "GET";
@@ -40,8 +42,15 @@ export class HttpRequest implements HttpMessage, HttpEndpoint {
   }
 
   static isInstance(request: unknown): request is HttpRequest {
+    //determine if request is a valid httpRequest
+    const req: any = request;
     return (
-      request !== undefined && (request as HttpRequest).isHttpRequest === true
+      "method" in req &&
+      "protocol" in req &&
+      "hostname" in req &&
+      "path" in req &&
+      typeof req["query"] === "object" &&
+      typeof req["headers"] === "object"
     );
   }
 
@@ -57,6 +66,28 @@ export class HttpRequest implements HttpMessage, HttpEndpoint {
     return `${this.protocol}//${hostname}${this.path}${queryString}`;
   }
 
+  clone(): HttpRequest {
+    const cloned = new HttpRequest({
+      ...this,
+      headers: { ...this.headers }
+    });
+    if (cloned.query) cloned.query = this.cloneQuery(cloned.query);
+    return cloned;
+  }
+
+  private cloneQuery(query: QueryParameterBag): QueryParameterBag {
+    return Object.keys(query).reduce(
+      (carry: QueryParameterBag, paramName: string) => {
+        const param = query[paramName];
+        return {
+          ...carry,
+          [paramName]: Array.isArray(param) ? [...param] : param
+        };
+      },
+      {}
+    );
+  }
+
   private buildQueryString(): string {
     const parts: string[] = [];
     for (let key of Object.keys(this.query || {}).sort()) {

packages/protocol-http/src/httpRequest.ts

@@ -1,14 +1,15 @@
 import {
   HttpMessage,
-  HttpEndpoint,
-  QueryParameterBag,
-  HeaderBag
-} from "./http";
+  HeaderBag,
+  HttpResponse as IHttpResponse
+} from "@aws-sdk/types";
 
 type HttpResponseOptions = Partial<HttpMessage> & {
   statusCode: number;
 };
 
+export interface HttpResponse extends IHttpResponse {}
+
 export class HttpResponse {
   public statusCode: number;
   public headers: HeaderBag;

packages/protocol-http/src/httpResponse.ts

@@ -1,4 +1,3 @@
 export * from "./httpResponse";
 export * from "./httpRequest";
 export * from "./httpHandler";
-export * from "./http";

packages/protocol-http/src/index.ts

@@ -9,6 +9,7 @@
     "importHelpers": true,
     "noEmitHelpers": true,
     "lib": [
+      "dom",
       "es5",
       "es2015.promise",
       "es2015.collection",