fixup! feat: support @httpApiKeyAuth trait

Author: glb

smithy-typescript-codegen/src/main/resources/software/amazon/smithy/typescript/codegen/integration/http-api-key-auth.spec.ts

@@ -56,7 +56,7 @@ describe("httpApiKeyAuthMiddleware", () => {
       jest.clearAllMocks();
     });
 
-    it("should throw an error if the location is `query`", async () => {
+    it("should set the query parameter if the location is `query`", async () => {
       const middleware = httpApiKeyAuthMiddleware(
         {
           apiKey: "exampleApiKey",
@@ -69,14 +69,15 @@ describe("httpApiKeyAuthMiddleware", () => {
 
       const handler = middleware(mockNextHandler, {});
 
-      await expect(
-        handler({
-          input: {},
-          request: new HttpRequest({}),
-        })
-      ).rejects.toThrow("query parameter is not supported");
+      await handler({
+        input: {},
+        request: new HttpRequest({}),
+      });
 
-      expect(mockNextHandler.mock.calls.length).toEqual(0);
+      expect(mockNextHandler.mock.calls.length).toEqual(1);
+      expect(
+        mockNextHandler.mock.calls[0][0].request.query.key
+      ).toBe("exampleApiKey");
     });
 
     it("should throw an error if the api key has not been set", async () => {
@@ -169,4 +170,3 @@ describe("httpApiKeyAuthMiddleware", () => {
     });
   });
 });
-

smithy-typescript-codegen/src/main/resources/software/amazon/smithy/typescript/codegen/integration/http-api-key-auth.ts

@@ -93,10 +93,8 @@ export const httpApiKeyAuthMiddleware =
         ? `${options.scheme} ${resolvedConfig.apiKey}`
         : resolvedConfig.apiKey;
     } else if (options.in === "query") {
-      // It's terrifying that this is an option; API keys should not be part of the URL.
-      throw new Error(
-        "Sorry, passing the API key in a query parameter is not supported yet."
-      );
+      // Set the query parameter, even if it's already been set.
+      request.query[options.name] = resolvedConfig.apiKey;
     }
 
     return next(args);
@@ -122,4 +120,3 @@ export const getHttpApiKeyAuthPlugin = (
     );
   },
 });
-