fixup! feat: support @httpApiKeyAuth trait

Author: glb

smithy-typescript-codegen/src/main/resources/software/amazon/smithy/typescript/codegen/integration/http-api-key-auth.spec.ts

@@ -80,7 +80,7 @@ describe("httpApiKeyAuthMiddleware", () => {
       ).toBe("exampleApiKey");
     });
 
-    it("should throw an error if the api key has not been set", async () => {
+    it("should skip if the api key has not been set", async () => {
       const middleware = httpApiKeyAuthMiddleware(
         {},
         {
@@ -92,14 +92,12 @@ describe("httpApiKeyAuthMiddleware", () => {
 
       const handler = middleware(mockNextHandler, {});
 
-      await expect(
-        handler({
-          input: {},
-          request: new HttpRequest({}),
-        })
-      ).rejects.toThrow("no API key was provided");
+      await handler({
+        input: {},
+        request: {},
+      });
 
-      expect(mockNextHandler.mock.calls.length).toEqual(0);
+      expect(mockNextHandler.mock.calls.length).toEqual(1);
     });
 
     it("should skip if the request is not an HttpRequest", async () => {

smithy-typescript-codegen/src/main/resources/software/amazon/smithy/typescript/codegen/integration/http-api-key-auth.ts

@@ -83,10 +83,10 @@ export const httpApiKeyAuthMiddleware =
     if (!HttpRequest.isInstance(args.request)) return next(args);
 
     // This middleware will not be injected if the operation has the @optionalAuth trait.
+    // We don't know if we're the only auth middleware, so let the service deal with the
+    // absence of the API key (or let other middleware do its job).
     if (!pluginConfig.apiKey) {
-      throw new Error(
-        "API key authorization is required but no API key was provided in the client configuration"
-      );
+      return next(args);
     }
 
     return next({