Skip to content

Commit f84179a

Browse files
committed
Used positional parameters in write() calls
1 parent 4dde917 commit f84179a

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructuredMemberWriter.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -144,17 +144,16 @@ void writeFilterSensitiveLog(TypeScriptWriter writer, Shape shape) {
144144
String memberName = TypeScriptUtils.sanitizePropertyName(symbolProvider.toMemberName(member));
145145
if (member.getMemberTrait(model, SensitiveTrait.class).isPresent()) {
146146
// member is Sensitive, hide the value.
147-
writer.write("...(obj.$L && { $L: SENSITIVE_STRING }),", memberName, memberName);
147+
writer.write("...(obj.$1L && { $1L: SENSITIVE_STRING }),", memberName);
148148
} else if (memberShape instanceof StructureShape) {
149149
// Call filterSensitiveLog on Structure.
150-
writer.write("...(obj.$L && { $L: $T.filterSensitiveLog(obj.$L)}),",
151-
memberName, memberName, symbolProvider.toSymbol(member), memberName);
150+
writer.write("...(obj.$1L && { $1L: $2T.filterSensitiveLog(obj.$1L)}),",
151+
memberName, symbolProvider.toSymbol(member));
152152
} else if (memberShape instanceof CollectionShape) {
153153
MemberShape collectionMember = ((CollectionShape) memberShape).getMember();
154154
if (isIterationRequired(collectionMember)) {
155155
// Iterate over array items, and call array specific function on each member.
156-
writer.openBlock("...(obj.$L && { $L: obj.$L.map(", ")}),",
157-
memberName, memberName, memberName,
156+
writer.openBlock("...(obj.$1L && { $1L: obj.$1L.map(", ")}),", memberName,
158157
() -> {
159158
writeCollectionFilterSensitiveLog(writer, collectionMember);
160159
}
@@ -164,8 +163,7 @@ void writeFilterSensitiveLog(TypeScriptWriter writer, Shape shape) {
164163
MemberShape mapMember = ((MapShape) memberShape).getValue();
165164
if (isIterationRequired(mapMember)) {
166165
// Iterate over Object entries, and call reduce to repopulate map.
167-
writer.openBlock("...(obj.$L && { $L: Object.entries(obj.$L).reduce(", ")}),",
168-
memberName, memberName, memberName,
166+
writer.openBlock("...(obj.$1L && { $1L: Object.entries(obj.$1L).reduce(", ")}),", memberName,
169167
() -> {
170168
writeMapFilterSensitiveLog(writer, mapMember);
171169
}

0 commit comments

Comments
 (0)