Skip to content

fix: return throwDefaultError as never #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Feb 5, 2024

Now that the container function returns Promise<never>, no reachable statement that isn't also never is allowed

@kuhe kuhe requested review from a team as code owners February 5, 2024 17:28
@kuhe kuhe requested a review from AndrewFossAWS February 5, 2024 17:28
@@ -357,7 +357,7 @@ static Set<StructureShape> generateUnifiedErrorDispatcher(

// Get the protocol specific error location for retrieving contents.
String errorLocation = bodyErrorLocationModifier.apply(context, "parsedBody");
writer.openBlock("return throwDefaultError({", "})", () -> {
writer.openBlock("return throwDefaultError({", "}) as never", () -> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is easier than releasing a change to the return type of throwDefaultError, which may cause instability in existing clients

@kuhe kuhe merged commit ceb489e into smithy-lang:main Feb 5, 2024
@kuhe kuhe deleted the fix/error-serde branch February 5, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants