Skip to content

strip internal API, endpoint and test files from API reference #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2021

Conversation

AllanZhengYP
Copy link
Contributor

Description of changes:
This change annotates the config entries that only required by internal implementation as @internal. The generated API reference will strip them too. This is to inform the users not to set some values in the clients that could potentially break the SDK.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from trivikr May 12, 2021 19:51
@AllanZhengYP
Copy link
Contributor Author

Generated clients shown in PR: aws/aws-sdk-js-v3#2388

@AllanZhengYP AllanZhengYP merged commit da34357 into smithy-lang:main May 14, 2021
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
…y-lang#337)

* mark clients internal configs

* docs: strip internal API, endpoint and test files in reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants