Generate unique error response deserializers #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the abstact `ProtocolGenerator` implementations to generate unique error response deserializers. This supports error shapes that have HTTP bindings in the `HttpBindingProtocolGenerator` as well as adding `$metadata` contents to errors. This commit also includes minor updates to move from `let` to `const`.
mtdowling
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate unique error response deserializers
This commit updates the abstact
ProtocolGeneratorimplementationsto generate unique error response deserializers. This supports error
shapes that have HTTP bindings in the
HttpBindingProtocolGeneratoras well as adding
$metadatacontents to errors.This commit also includes minor updates to move from
lettoconst.Fix Error structure interface extensions
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.